Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RTL tests to @shared/UsaIcon.jsx #4668

Closed
6 tasks done
Tracked by #4014
apburnes opened this issue Nov 20, 2024 · 0 comments · Fixed by #4698
Closed
6 tasks done
Tracked by #4014

Add RTL tests to @shared/UsaIcon.jsx #4668

apburnes opened this issue Nov 20, 2024 · 0 comments · Fixed by #4698
Assignees
@sknep
Labels
squad-pages

Comments

@apburnes
Copy link
Contributor

apburnes commented Nov 20, 2024 •
edited by sknep
Loading

Add a test to @shared/UsaIcon.jsx using the RTL framework. See our docs for writing frontend tests.

Acceptance Criteria

  • Colocate test file to @shared/UsaIcon.test.jsx
  • Test the icon is showing as expected
  • Test when the icon is focusable
  • Test the size property
  • Test the role property
  • Remove component defaultProps and add the to the component args
@apburnes apburnes mentioned this issue Dec 2, 2024
Open
@apburnes apburnes assigned apburnes and sknep and unassigned apburnes Dec 16, 2024
sknep added a commit that referenced this issue Dec 20, 2024
@sknep
chore: test @shared/UsaIcon.jsx #4668
669a9a4
@sknep sknep mentioned this issue Dec 20, 2024
Merged
@sknep sknep linked a pull request Dec 20, 2024 that will close this issue
chore: refactor @shared/UsaIcon.jsx and test #4668 #4698
Merged
sknep added a commit that referenced this issue Dec 20, 2024
@sknep
Merge pull request #4698 from cloud-gov/chore-test-shared-usaIcon-4668
09fb316 
chore: refactor @shared/UsaIcon.jsx and test  #4668
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sknep sknep

Labels
squad-pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: refactor @shared/UsaIcon.jsx and test #4668 cloud-gov/pages-core
2 participants
@apburnes @sknep