Use unittest instead of setuptools (where possible)
#161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movermeyer
force-pushed
the
movermeyer/use_unittest
branch
4 times, most recently
from
db414ed
to
a8013a3
Compare
movermeyer
changed the title
unittest instead of setuptoolstox and unittest instead of setuptools (where possible)
movermeyer
changed the title
tox and unittest instead of setuptools (where possible)unittest instead of setuptools (where possible)
movermeyer
force-pushed
the
movermeyer/use_unittest
branch
8 times, most recently
from
bdabcd2
to
19b8b93
Compare
movermeyer
commented
Nov 10, 2024
| - run: | ||
| name: Test | ||
| command: pypy setup.py test | ||
| <<: *tests |
There was a problem hiding this comment.
Reducing duplication using YAML anchors.
movermeyer
force-pushed
the
movermeyer/use_unittest
branch
2 times, most recently
from
a9ff45e
to
d693753
Compare
movermeyer
force-pushed
the
movermeyer/use_unittest
branch
from
d693753
to
f0157ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
setuptoolshas dropped its test-running capabilities in v72.Python 3.12 dropped
setuptoolsfrom the builtins.My hope is that we'll be able to use PEP 517-compatible methods for testing on modern Pythons (#147), while still keeping the old
setup.pymethod for old versions. We'll see.What approach did you choose and why?
If you are testing a pure-Python module, you can simply call
python -m unittestto have your tests run.However, since we're a compiled C-extension, we have to create the source distribution and install it first.
What should reviewers focus on?
🤷
The impact of these changes
We are testing using the preferred method, at least for modern Pythons.