Fix bootstrapping ids for relating objects like indexes #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
requested changes
Jan 29, 2024
bfops
added
abi-break
cloutiertyler
changed the title
gefjon
approved these changes
Feb 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Centril
force-pushed
the
mamcx/fix-bootstrap-system-ids
branch
from
fd2d3ee
to
95cc968
Compare
|
Went ahead and rebased this for ya :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The bootstrapping of system tables keeps the ids of related objects as
0because is calledschema_for_tablethat first consults the cache.Now, after the bootstrapping is done, re-read the data from the database to be sure the correct
idsare assigned.API and ABI breaking changes
This is an internal break because the
system tablesschemas get0for all the dependant objectsidsand now get the correct one.Expected complexity level and risk
1