Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Run tools/publish-crates.sh --dry-run #1961

Draft
wants to merge 3 commits into
base: bfops/bump-version
Choose a base branch
from

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Nov 7, 2024

Description of Changes

We keep discovering issues during release, e.g. due to missing LICENSE files.

This adds tools/publish-crates.sh --dry-run as a CI step, so we will learn of these issues when they are initially introduced, instead of during release.

Once this is merged, we should make it a required check.

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

  • CI fails initially, since we have not added the expr crate to the publish list
  • CI passes now

@bfops bfops added no runtime change This change does not affect the final binaries release-any To be landed in any release window labels Nov 7, 2024
@bfops bfops changed the base branch from master to bfops/bump-version November 7, 2024 21:59
@bfops bfops marked this pull request as draft November 7, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no runtime change This change does not affect the final binaries release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant