Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commitlog: Yield StoredCommit in iterators #1791

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

kim
Copy link
Contributor

@kim kim commented Oct 2, 2024

This provides access to the checksum, which may be of interest.
Leaving the History trait as-is, as there is no immediate need for the
checksum.

Also fix rustdoc warnings.

@kim kim requested a review from Shubham8287 October 2, 2024 11:51
This provides access to the checksum, which may be of interest.
Leaving the `History` trait as-is, as there is no immediate need for the
checksum.
@kim kim force-pushed the kim/commitlog/stored-commit-iter branch from d6331df to 04b242a Compare October 8, 2024 07:31
Copy link
Contributor

@Shubham8287 Shubham8287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks reasonable.

@kim kim added this pull request to the merge queue Oct 8, 2024
Merged via the queue into master with commit afeb342 Oct 8, 2024
8 checks passed
@kim kim deleted the kim/commitlog/stored-commit-iter branch October 8, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants