bindings-csharp: pass address_1
#1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance you could add a regression test (modify sdk-test and sdk-test-cs to insert the received Identity and Address somewhere)? |
lcodes
approved these changes
Aug 21, 2024
RReverser
approved these changes
Aug 21, 2024
Signed-off-by: Mazdak Farrokhzad <[email protected]>
These reducers were there in the SDK tests already, but were never called or used.
Centril
force-pushed
the
centril/fix-call-reducer-csharp
branch
from
aa5c2f1
to
b7322d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes a bug where
address_0was passed twice.