Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Post-to-discord workflow only fires if the PR merged to master #1520

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Jul 16, 2024

Description of Changes

The post-to-discord workflow was firing any time a PR merged, which included PRs merging to non-master branches. That's a bit noisy.

API and ABI breaking changes

Nah

Expected complexity level and risk

1

Testing

@bfops bfops requested a review from jdetter July 16, 2024 16:57
Co-authored-by: Zeke Foppa <github.com/bfops>
@bfops bfops marked this pull request as ready for review July 16, 2024 17:05
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, thanks 👍

@bfops bfops enabled auto-merge July 16, 2024 17:10
@bfops bfops added this pull request to the merge queue Jul 16, 2024
Merged via the queue into master with commit 2b291b0 Jul 16, 2024
10 checks passed
@bfops bfops deleted the bfops/discord-workflow-teak branch July 16, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants