Fixed exceptions in C# SDK when someone disconnects or when a transaction originates from CLI #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion originates from CLI
jdetter
reviewed
Jun 26, 2024
| @@ -712,6 +712,8 @@ pub fn autogen_csharp_globals(items: &[GenItem], namespace: &str) -> Vec<(String | |||
| ); | |||
| } | |||
| writeln!(output, "\"<none>\" => null,"); | |||
| writeln!(output, "\"__identity_disconnected__\" => null,"); | |||
There was a problem hiding this comment.
why only __identity_disconnected__ here and not also __identity_connected__?
There was a problem hiding this comment.
FWIW in modules we treat all events that start with __ and end with __ as "special" in various places.
Could do the same here instead of hardcoding a few names.
jdetter
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
IMO We should allow users to subscribe to these events instead of just suppressing the errors here, I've created an issue in the C# SDK: clockworklabs/com.clockworklabs.spacetimedbsdk#102
I can understand the BitCraft team not wanting to have to deal with these errors as they're doing development on the game so I'm fine to approve this as-is for now.
bfops
pushed a commit
that referenced
this pull request
Jun 26, 2024
…C# SDK when someone disconnects or when a transaction originates from CLI Co-authored-by: Steve Boytsun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial
Description of Changes
Expected complexity level and risk
Complexity: 1/5
Risk: 1/5
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!