Shub/st connected clients #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
force-pushed
the
shub/st-connected-clients
branch
from
488e88e
to
43cc06c
Compare
Shubham8287
force-pushed
the
shub/st-connected-clients
branch
from
a5fcca4
to
ede24aa
Compare
kim
approved these changes
May 24, 2024
Centril
reviewed
May 24, 2024
Comment on lines
+754
to
+760
| .iter_by_col_eq_mut( | ||
| ctx, | ||
| mut_tx, | ||
| ST_CLIENTS_ID, | ||
| col_list![StClientsFields::Identity, StClientsFields::Address], | ||
| &algebraic_value::AlgebraicValue::product(row), | ||
| )? |
There was a problem hiding this comment.
@cloutiertyler I feel like this makes #1287 and #1097 more of a priority as we are comparing against:
product![product![AlgebraicValue::Bytes(vec![...].into())], product![AlgebraicValue::Bytes(vec![...].into())]]as opposed to:
product![AlgebraicValue::U256(Box::new(...)), AlgebraicValue::U128(...)]
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kim
added a commit
that referenced
this pull request
Jun 11, 2024
When opening a `RelationalDB`, determine the set of dangling clients (`ConnectedClients`) by scanning the `st_clients` table instead of tracking unmatched `__identity_connected__` calls during history replay. We left the replay tracking in place in #1288, treating the commitlog as the sole source of truth. With #1344 (snapshotting), this is no longer correct: the snapshot may contain rows in `st_clients`, but leave no history suffix for replay.
Centril
pushed a commit
that referenced
this pull request
Jun 11, 2024
When opening a `RelationalDB`, determine the set of dangling clients (`ConnectedClients`) by scanning the `st_clients` table instead of tracking unmatched `__identity_connected__` calls during history replay. We left the replay tracking in place in #1288, treating the commitlog as the sole source of truth. With #1344 (snapshotting), this is no longer correct: the snapshot may contain rows in `st_clients`, but leave no history suffix for replay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
st_clientstable to keep track of connected clients.__identity_connect__reducer transaction.API and ABI breaking changes
N/A
Expected complexity level and risk
2
Testing