perf(JoinInner
): use AVs for keys instead of PVs
#1194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
join_inner
logic from spacetimedb_vm.ColIds
injoin_inner
and don't recompute it for every element.AlgebraicValue
keys inJoinInner
as opposed toProductValue
. This removes an allocation per map entry.JoinInner
callbacks infallible.JoinInner::next
, avoid clones unless necessary.3-6 collectively, but primarily 4, results in the following perf improvements compared to HEAD~1 on i7-7700K, 64GB RAM:
API and ABI breaking changes
None
Expected complexity level and risk
1