Revert toolchain to 1.69 because upstream bug on wasmer for macOS M CPUs #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
commented
Jul 26, 2023
| || module | ||
| .find_std_section::<wasmbin::sections::payload::Export>() | ||
| .and_then(|exports| exports.try_contents().ok()) | ||
| .is_some_and(|exports| exports.iter().any(check_export)) |
There was a problem hiding this comment.
This was unstable in 1.69
mamcx
commented
Jul 26, 2023
| @@ -386,7 +386,6 @@ impl InstanceEnv { | |||
| } | |||
|
|
|||
| #[tracing::instrument(skip_all)] | |||
| #[allow(clippy::let_with_type_underscore)] // I have no idea why clippy is issuing this warning | |||
There was a problem hiding this comment.
Removed because have not effect in both toolchains
mamcx
commented
Jul 26, 2023
| @@ -1,5 +1,3 @@ | |||
| #![allow(clippy::let_with_type_underscore)] // can remove once tokio-rs/tracing#2609 mereges | |||
There was a problem hiding this comment.
Removed because have not effect in both toolchains
Centril
approved these changes
Jul 26, 2023
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
1.69so running in standalone works on macOs: Misaligned pointer dereference on Mac M1 Pro & Mac M2 Pro wasmerio/wasmer#4072This is triggered by running reduces by bitCraft, for example.
API
If the API is breaking, please state below what will break