Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement consistent filtering rules proposal #1256

Closed
5 tasks done
cloutiertyler opened this issue May 20, 2024 · 0 comments
Closed
5 tasks done

Implement consistent filtering rules proposal #1256

cloutiertyler opened this issue May 20, 2024 · 0 comments
Assignees
@RReverser @gefjon

Comments

@cloutiertyler
Copy link
Contributor

cloutiertyler commented May 20, 2024 •
edited by RReverser
Loading

Progress:
@RReverser RReverser mentioned this issue May 22, 2024
Merged
3 tasks
RReverser added a commit that referenced this issue May 22, 2024
@RReverser
Implement consistent filtering rules for TypeScript
d6cbed8 
- Limit types to those defined in the consistent filtering proposal (#1256).
- Make `filterBy` a lazy iterable for consistency and performance reasons.
- Add `findBy` for unique fields as per proposal.
This was referenced May 22, 2024
Merged
Merged
Merged
Merged
RReverser added a commit that referenced this issue May 28, 2024
@RReverser
Implement consistent filtering rules for TypeScript
5fa0878 
- Limit types to those defined in the consistent filtering proposal (#1256).
- Make `filterBy` a lazy iterable for consistency and performance reasons.
- Add `findBy` for unique fields as per proposal.
RReverser added a commit to clockworklabs/com.clockworklabs.spacetimedbsdk that referenced this issue May 28, 2024
@RReverser
Simplify update handling as per consistent filtering proposal (#93)
025a84c 
## Description of Changes

As a result of the consistent filtering rules proposal
(clockworklabs/SpacetimeDB#1256), all equatable types are now natively
equatable in C# as well.

This allows us to compare objects directly, without holding and
comparing AlgebraicValue in the entries map as well, which has a bit of
a domino effect and allows to optimise, simplify or even remove some
parts of the SDK.

## API

 - [x] This is an API breaking change to the SDK

New filtering rules limit types on which filtering can be done, as well
as change the return type of `FilterBy` functions to always be iterable.

## Requires SpacetimeDB PRs

clockworklabs/SpacetimeDB#1277
github-merge-queue bot pushed a commit that referenced this issue May 28, 2024
@RReverser
Implement consistent filtering rules for TypeScript (#1276)
ac0c097 
- Limit types to those defined in the consistent filtering proposal (#1256).
- Make `filterBy` a lazy iterable for consistency and performance reasons.
- Add `findBy` for unique fields as per proposal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RReverser RReverser

@gefjon gefjon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RReverser @cloutiertyler @gefjon