Skip to content

Conversation

@DerGuteMoritz
Copy link
Collaborator

Since it came up a few times now, I looked into making zstd and brotli optional again. Turns out there was a pretty easy workaround (see second commit). With this branch, the repro from #703 doesn't crash anymore.

Copy link
Collaborator

@KingMob KingMob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we're just shifting around the set of people who will complain :)

Though truthfully, based on the number of downloads I see on Clojars, I don't think Aleph is used much anymore, so there probably won't be many complaints.

@DerGuteMoritz
Copy link
Collaborator Author

I wonder if we're just shifting around the set of people who will complain :)

True. I guess we could have another vote about it but given the meager turnout last time...

Though truthfully, based on the number of downloads I see on Clojars, I don't think Aleph is used much anymore, so there probably won't be many complaints.

Hmm indeed.... judging from these, at best there are maybe still 1000 users around? Perhaps it's time for a bit of a marketing campaign to re-ignite its popularity 😄

The Clojure implementation needed a hacky workaround[1] which felt too fragile after all.

[1] Due to https://clojure.atlassian.net/browse/CLJ-2842
Copy link
Collaborator

@KingMob KingMob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think it's much safer to move this to Java.

@DerGuteMoritz DerGuteMoritz merged commit f887290 into master Apr 9, 2024
@DerGuteMoritz DerGuteMoritz deleted the make-brotli-and-zstd-optional-again branch April 9, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants