correctly convert from flashes per five minutes to flashes per minute#16
Merged
climbfuji merged 2 commits intoMar 11, 2024
Conversation
climbfuji
approved these changes
Mar 11, 2024
Owner
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Thanks very much for fixing my code!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conversion in the fix_units_flashes_per_5min is incorrect. This does it properly. I've confirmed by running the original version against these changes. Differences are on the order of 1e-6.