Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre commit tweaks #12

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Pre commit tweaks #12

merged 6 commits into from
Nov 21, 2023

Conversation

harrisonpim
Copy link
Contributor

drive-by PR with some tiny tweaks, while setting up the targets-sprint-cop28 repo

  • tidies up the dev dependency groups
  • adds a poetry lock file check
  • autoformats with ruff instead of black (including notebooks)

Copy link

@mpjuhasz mpjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- any particular reason why we should be moving to ruff from black?

@harrisonpim
Copy link
Contributor Author

there are a couple of reasons:

all of those reasons are minor though, so i'm happy to be swayed back to black if people have stronger feelings!

@kdutia
Copy link
Member

kdutia commented Nov 20, 2023

@harrisonpim
Copy link
Contributor Author

it's there already, but in a different way! i've verified that it works with both scripts and notebooks

@harrisonpim harrisonpim merged commit 9b2e07f into main Nov 21, 2023
4 checks passed
@harrisonpim harrisonpim deleted the pre-commit-tweaks branch November 21, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants