Skip to content

Mock mod#120

Closed
prajeeshag wants to merge 2 commits intoclick-contrib:masterfrom
prajeeshag:mock_mod
Closed

Mock mod#120
prajeeshag wants to merge 2 commits intoclick-contrib:masterfrom
prajeeshag:mock_mod

Conversation

@prajeeshag
Copy link

Summary

Tasks

  • Added unit tests
  • Added documentation for new features (where applicable)
  • Added release notes (using reno)
  • Ran test suite and style checks and built documentation (tox)

Further details

@peytondmurray
Copy link
Contributor

Hey, I'd really like to see mocking capability merged into sphinx-click. Is there anything I can do to move this PR along?

Also, does it make sense to use autodoc_mock_modules here? In my use case I'd sure like to just be able to define mocks in one place, rather than having to specify a separate list of click_mock_imports.

I'd be happy to make a PR against this branch if needed - just let me know how I can help.

@prajeeshag
Copy link
Author

Hi @peytondmurray, Thanks for your interest in merging mocking capability.

Yes, autodoc_mock_modules can be used directly, and I don't see any need for a separate list. I don't remember why I created that.

Please feel free to create a PR, and pardon me if I am saying something stupid here because I have no prior experience in contributing to an open-source project. I don't know the process. Your help in this regard is really appreciated, thanks.

@peytondmurray peytondmurray mentioned this pull request Nov 9, 2023
4 tasks
@stephenfin
Copy link
Member

Looks like this has stagnated so I'm going to close. Please reopen if you'd like to continue working on this

@stephenfin stephenfin closed this Apr 5, 2024
@stephenfin
Copy link
Member

Also, @peytondmurray did this in #129. Whoops 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants