feat(index): serve open-file header symbols from PCH preamble index

[16bit-ykiko]

Problem

For open (in-memory) files, everything before the preamble bound is compiled into the PCH and invisible to the per-edit index: the headers' contents, the preamble region's own directives, and — crucially — the compilation context the buffer's preamble defines, which may match no disk TU the background indexer has ever seen. Header-internal data cannot be recovered from the consuming compile either: enumerating the TU's decls triggers full PCH deserialization, and referenced decls only bring in their declarations, never the references inside other decls' bodies.

Concrete symptoms:

• go-to-definition / find-references from an open file into its headers returns empty when the disk index does not cover them (the known in-memory-file bug: open files' TUs are skipped by background indexing).
• Results are blind to unsaved preamble edits (#define before an #include activating an #ifdef branch no disk context ever indexed).
• Cursor on a #define in the preamble region resolves to nothing.
• Preamble document links were never persisted — lost on every restart despite a PCH cache hit.

The PCH build actually produced a full index of the preamble all along (handle_build_pch → serialize_tu_index), but the master dropped it on the floor.

Design

PreambleState blob, paired with the PCH. The stateless worker serializes the preamble's state at build time — the only moment the freshly parsed preamble AST is in memory, so no PCH deserialization is ever needed:

• the preamble's full symbol index: every covered header (occurrences, relations, per-file content + line tables for position mapping) plus the main file's preamble region in buffer coordinates;
• the PCH-derived feature state that used to live in loose PCHState fields: document links, inactive regions, the open conditional stack.

The blob is written directly to a store tmp path (no more multi-MB IPC payloads) — strictly after the PCH itself is flushed, so the pair's on-disk mtimes match its logical order — then opened by the master as a memory-mapped FlatBuffer and queried zero-copy, mirroring MergedIndex's read path.

CacheStore paired blobs. A namespace may declare an aux_extension (pch → .pch.idx): one key owns two files forming a single entry — sized, aged and evicted together. The pair is only served complete: eviction removes aux before primary, a republished primary resets the stale aux, a missing half is a plain cache miss that rebuilds both, and restart adoption drops an aux older than its primary (removal residue). Both commits run as one thread-pool job, so a cancellation can never publish half a pair; the blob is also verified there, keeping the flatbuffer verification walk off the event loop.

Query overlay (LSP). Open sessions overlay their PCH blobs onto index queries:

• Set queries (references, hierarchy ranges) take the union of overlay rows and disk shards, deduplicated by location — identical rows collapse, live-context-only rows survive. Only the open file's own disk shard is skipped (existing is_path_open behavior; the Workspace invariant that an open file affects only itself is preserved).
• Single-answer queries (definition location, symbol info, definition text) prefer the overlay over disk shards.
• The buffer's preamble region (macros before the bound) resolves through the blob's main-file entry. The blob stores the exact preamble text the PCH was built from; the entry serves only the file that built it (identical preambles share a PCH, but macro USRs embed the source path) and only while the buffer still starts with that text — the prefix comparison is the whole freshness check, since body edits never move preamble rows. Paths are compared through the path pool, which normalizes separators (raw comparison never matches clang's backslash paths on Windows).
• Overlay rows are excluded for files that are themselves open (their sessions are authoritative — disk-snapshot coordinates must not map onto an edited buffer), for synthesized context artifacts, and for builtin pseudo files.

Agentic queries serve disk truth. Agents read files from disk, so buffer-derived state would hand them coordinates for text they cannot see. A plain IndexQueryOptions{.disk_only} on the query layer gives the agent endpoint its own IndexQuery that skips sessions, overlays and preamble entries entirely — same code paths, one option, no parallel type hierarchy. Complementing that:

• Background indexing skips open files while only LSP is attached (their sessions serve everything); the first agentic index query flips a sticky index_open_files and enqueues a catch-up for every open session, choosing ContentChanged vs DepsOnly by comparing disk content against the existing shard — a stale shard must not answer agents with pre-save rows while it waits.
• Disk-affecting events on open files (save, external disk change, compile-command change) queue the file's own reindex as well, so the shard tracks disk truth once an agent is around; a CDB change also evicts the shard, which content-only freshness validation cannot see through.
• All agentic handlers sit behind the same shard gate (freshness contract, clause 2): a shard whose file changed on disk serves nothing until its reindex lands.

PCM is deliberately untouched: module units are ordinary disk files with CDB entries and belong to the normal background-indexing path (TODO left in handle_build_pcm).

Also fixed along the way

• preamble_links were never written to cache.json — preamble document links now survive restarts via the blob (regression test included), and DocumentLink carries offsets internally with LSP conversion only at the reply edge.
• The preamble compile's main-file index was explicitly discarded (serialize_tu_index cleared it) — kept now, enabling preamble-region cursor resolution.
• Macro symbols had nameless symbol-table entries (build()'s reference-files loop default-constructed them); handleMacroOccurrence now records name/kind, and macro definition relations carry the full #define extent.
• Real -include files are unaffected by the synthetic-buffer filter (clang records their include edge in the predefines buffer) — proven by a regression test.
• Blob-write failures are classified as internal errors (anomaly) and carry the concrete cause; a crashed worker's stack trace now surfaces in integration-test failures.
• Agentic status reports from indexing-round progress instead of the live queue (which compacts between rounds); agentic test fixtures stop paying the 3s idle timer.
• cache_format_version 3 → 4 (tests/tools/workspace.py synced).

Testing

• Unit (888 passing): PreambleState roundtrip/lookups/version- and corruption-rejection/forced-include preservation; CacheStore pairing (atomic eviction, orphan sweep, recommit reset, stale-aux adoption, half-pair self-healing); query overlay (union+dedup, overlay-outranks-disk, open-header exclusion, preamble drift gating, shared-PCH scoping, synthesized-artifact filtering, hierarchy and agentic dedup, preamble macro cursor, disk-only agent queries); invalidator open-file catch-up semantics; worker blob production and write-failure classification.
• Integration (270 passing): definition/references into an unindexed header (the original bug, reproduced with indexing disabled); buffer-context divergence via didChange (#ifdef branch only the live preamble activates); no duplicate rows when shard and overlay coexist; preamble #define navigation; links surviving restart with a verified PCH cache hit; deleted .pch.idx rebuilding the pair; on-disk header edits refreshing a same-key overlay; the agentic suite exercising disk-truth answers and the open-file catch-up.
• Smoke: 3/3.
• Full matrix green on ubuntu/macos/windows-2025 plus aarch64/windows-arm64/macos-x64 cross-tests (the Windows path-separator fix is covered by the QueryOverlay preamble tests, which fail without it).
• Pre-PR three-way subagent review (correctness / style / tests) completed; all P0/P1 findings fixed.

Design docs (symbol-index.md, incremental-parse.md, en + zh) updated; the "PCH-induced index split" known limitation is now marked resolved.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds a FlatBuffer-backed PreambleState paired with each PCH, updates cache and worker publication flows, and overlays preamble symbols, relations, definitions, references, and document links into queries with freshness and deduplication checks.

Changes

Preamble state and serialization

Layer / File(s)	Summary
Preamble-state format and serialization src/index/*, src/feature/*, tests/unit/index/*, tests/unit/feature/*	Defines the FlatBuffer schema and PreambleState API, serializes symbol and feature state, supports validated loading and binary-search lookups, and stores document-link ranges as local byte offsets.

Paired cache and PCH build lifecycle

Layer / File(s)	Summary
Paired cache and PCH build lifecycle src/support/cache_store.*, src/server/compiler/*, src/server/worker/*, src/server/state/workspace.*, src/server/protocol/worker.h, tests/unit/server/*, tests/unit/support/*, tests/integration/compilation/*	Stores, commits, loads, evicts, and rebuilds PCH blobs together with auxiliary preamble-state blobs, including worker serialization and cache recovery validation.

PCH overlay query resolution

Layer / File(s)	Summary
PCH overlay query resolution src/server/service/*, src/server/state/session.h, tests/integration/features/test_pch_overlay.py, tests/unit/server/query_overlay_tests.cpp	Adds synchronized PCH overlay traversal for symbol, cursor, relation, definition, reference, call, and document-link queries, with file filtering, overlay precedence, and result deduplication.

Documentation and integration validation

Layer / File(s)	Summary
Documentation and integration validation docs/{en,zh}/design/*, tests/integration/features/test_index.py, tests/tools/checks.py	Documents the resolved PCH index split and shares normalized location-result handling across integration tests.

Estimated code review effort: 5 (Critical) | ~120 minutes

Possibly related PRs

• clice-io/clice#382: Shares TU indexing and macro symbol/relation handling.
• clice-io/clice#413: Overlaps with PCH document-link generation and serving.
• clice-io/clice#453: Shares the store-based PCH cache lifecycle extended here with paired auxiliary blobs.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately summarizes the main change: serving open-file header symbols from the PCH preamble index.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch pch-index-overlay

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 3

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/server/service/feature_router.cpp (1)

40-54: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Guard preamble links against drift src/server/service/feature_router.cpp:40-54 — ast_dirty can be false while the session’s preamble has moved on, so find_preamble_links() can return stale link.range/target data for document_links() and GoToDefinition. Use the same bound check as preamble_in_sync() before serving these cached links.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/server/service/feature_router.cpp` around lines 40 - 54,
find_preamble_links() can return links from a preamble that no longer matches
the session. Add the same preamble-version/state bound check used by
preamble_in_sync() before loading or returning cached links, and return nullptr
when the session preamble has drifted; ensure document_links() and
GoToDefinition only consume links passing this guard.

🧹 Nitpick comments (5)

src/index/tu_index.cpp (1)

84-90: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Consider a direct unit test for macro symbol metadata.

Existing coverage (test_preamble_macro_definition in test_pch_overlay.py) exercises navigation but not the recorded name/kind themselves. A small tu_index-level or preamble_state-level assertion on find_symbol's returned name/kind for a macro symbol would directly protect this fix from regressing.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/index/tu_index.cpp` around lines 84 - 90, Add a focused unit test near
the existing preamble macro coverage that calls find_symbol for a macro and
asserts its recorded name equals the token spelling and its kind is
SymbolKind::Macro; use the relevant tu_index or preamble_state test fixture so
the metadata assignment in the symbol insertion path is directly validated.

src/index/schema.fbs (1)

206-239: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Consider marking main_file as (required). serialize() always emits it, so this would align the schema with the writer and make malformed blobs fail verification earlier. tests/unit/index/preamble_state_tests.cpp::RejectVersionMismatch would need a main_file offset.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/index/schema.fbs` around lines 206 - 239, Mark the
PreambleState.main_file field as required to match serialize() always emitting
it and enable earlier blob validation; update
tests/unit/index/preamble_state_tests.cpp::RejectVersionMismatch to provide a
main_file offset when constructing the fixture.

src/server/protocol/worker.h (1)

106-114: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Update the field-usage reference comment for the new BuildPCH field.

index_output_path is now a BuildPCH parameter but the selective-field summary at Lines 108-114 still reads BuildPCH: + content, preamble_bound, output_path. Worth adding index_output_path here so this quick-reference stays accurate.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/server/protocol/worker.h` around lines 106 - 114, Update the
selective-field summary comment for the unified task parameters to include
index_output_path in the BuildPCH field list, alongside content, preamble_bound,
and output_path.

src/support/cache_store.cpp (1)

329-378: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider asserting the documented aux/primary suffix-collision invariant.

The scan classifies aux files by ends_with(aux_ext) before primaries, which is correct for .pch/.pch.idx. However, the header documents "Must not be a suffix collision with extension" purely as a caller constraint — a future namespace whose extensions collide would silently misclassify primaries as aux (or delete real blobs as "orphan aux" at Lines 373-376). A cheap assert at registration would surface such a misconfiguration immediately rather than as silent data loss.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/support/cache_store.cpp` around lines 329 - 378, Validate the documented
suffix-collision constraint when namespaces are registered, asserting that the
configured aux extension cannot be a suffix of or otherwise collide with the
primary extension. Locate the namespace registration/configuration logic and add
a cheap debug assertion covering non-empty extensions before scanning can occur,
so invalid configurations fail immediately rather than misclassifying or
deleting blobs.

src/server/service/query.cpp (1)

46-65: 🚀 Performance & Scalability | 🔵 Trivial | 🏗️ Heavy lift

Overlay visitor re-runs once per open session sharing the same PCH.

visit_pch_overlays iterates every open session and, for each one, resolves session.pch_ref->key and re-invokes the visitor against the (possibly identical) PreambleState. When several open buffers share one PCH (a common case — many TUs compiled with the same flags), every caller of this helper (find_symbol_info, query_relations, find_definition_location, collect_grouped_relations, collect_unique_targets, get_definition_text, collect_references) redundantly re-runs state.lookup/state.find_symbol once per session instead of once per unique blob. Correctness is preserved by the downstream dedup, but the cost scales with open-session count rather than unique-PCH count.

Consider splitting "state-only" traversal (dedup by pch_ref->key, invoke once) from the per-session main-file-region pass (which genuinely needs each session's own line_map/ast_dirty/preamble_in_sync), so shared-PCH workspaces don't pay N× the lookup cost per query.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/server/service/query.cpp` around lines 46 - 65, Refactor
IndexQuery::visit_pch_overlays so PCH state traversal is deduplicated by
session.pch_ref->key and invokes the visitor once per unique PreambleState,
while retaining a separate per-session pass for main-file-region logic requiring
each session’s line_map, ast_dirty, or preamble_in_sync. Update callers such as
find_symbol_info, query_relations, find_definition_location,
collect_grouped_relations, collect_unique_targets, get_definition_text, and
collect_references to use the appropriate traversal.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/server/service/query.cpp`:
- Around line 783-811: The collect_references overlay handling only queries
header files and misses references from the preamble main-file region. Add a
state.lookup_main call alongside state.lookup, following the query_relations
pattern, and apply the same should-serve, position, deduplication, and result
construction logic used for overlay files.
- Around line 783-811: The overlay deduplication in the results collection loop
drops distinct references on the same line. Keep file-and-line keys for
pre-existing results, but use a finer-grained key including the overlay position
(such as pos->character or the relation byte offset) when tracking overlay-added
rows, so same-line distinct references are preserved while cross-source
duplicates remain filtered.
- Around line 660-690: Add a main-file lookup to the PCH overlay handling in
get_definition_text, mirroring find_definition_location and query_relations.
After or alongside the existing state.lookup call, invoke state.lookup_main for
RelationKind::Definition and apply the same file filtering, range validation,
line mapping, and DefinitionText construction so definitions in the preamble’s
main-file region are returned.

---

Outside diff comments:
In `@src/server/service/feature_router.cpp`:
- Around line 40-54: find_preamble_links() can return links from a preamble that
no longer matches the session. Add the same preamble-version/state bound check
used by preamble_in_sync() before loading or returning cached links, and return
nullptr when the session preamble has drifted; ensure document_links() and
GoToDefinition only consume links passing this guard.

---

Nitpick comments:
In `@src/index/schema.fbs`:
- Around line 206-239: Mark the PreambleState.main_file field as required to
match serialize() always emitting it and enable earlier blob validation; update
tests/unit/index/preamble_state_tests.cpp::RejectVersionMismatch to provide a
main_file offset when constructing the fixture.

In `@src/index/tu_index.cpp`:
- Around line 84-90: Add a focused unit test near the existing preamble macro
coverage that calls find_symbol for a macro and asserts its recorded name equals
the token spelling and its kind is SymbolKind::Macro; use the relevant tu_index
or preamble_state test fixture so the metadata assignment in the symbol
insertion path is directly validated.

In `@src/server/protocol/worker.h`:
- Around line 106-114: Update the selective-field summary comment for the
unified task parameters to include index_output_path in the BuildPCH field list,
alongside content, preamble_bound, and output_path.

In `@src/server/service/query.cpp`:
- Around line 46-65: Refactor IndexQuery::visit_pch_overlays so PCH state
traversal is deduplicated by session.pch_ref->key and invokes the visitor once
per unique PreambleState, while retaining a separate per-session pass for
main-file-region logic requiring each session’s line_map, ast_dirty, or
preamble_in_sync. Update callers such as find_symbol_info, query_relations,
find_definition_location, collect_grouped_relations, collect_unique_targets,
get_definition_text, and collect_references to use the appropriate traversal.

In `@src/support/cache_store.cpp`:
- Around line 329-378: Validate the documented suffix-collision constraint when
namespaces are registered, asserting that the configured aux extension cannot be
a suffix of or otherwise collide with the primary extension. Locate the
namespace registration/configuration logic and add a cheap debug assertion
covering non-empty extensions before scanning can occur, so invalid
configurations fail immediately rather than misclassifying or deleting blobs.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 90fe2bbc-9891-4604-8ae9-3db86683ae30

📥 Commits

Reviewing files that changed from the base of the PR and between 83719e5 and fba8b75.

📒 Files selected for processing (30)

• docs/en/design/incremental-parse.md
• docs/en/design/symbol-index.md
• docs/zh/design/incremental-parse.md
• docs/zh/design/symbol-index.md
• src/index/preamble_state.cpp
• src/index/preamble_state.h
• src/index/schema.fbs
• src/index/serialization.h
• src/index/tu_index.cpp
• src/server/compiler/compiler.cpp
• src/server/compiler/compiler.h
• src/server/protocol/worker.h
• src/server/service/feature_router.cpp
• src/server/service/query.cpp
• src/server/service/query.h
• src/server/state/workspace.cpp
• src/server/state/workspace.h
• src/server/transport/master_server.cpp
• src/server/worker/stateless_worker.cpp
• src/support/cache_store.cpp
• src/support/cache_store.h
• tests/integration/compilation/test_persistent_cache.py
• tests/integration/features/test_index.py
• tests/integration/features/test_pch_overlay.py
• tests/tools/checks.py
• tests/tools/workspace.py
• tests/unit/index/preamble_state_tests.cpp
• tests/unit/server/pch_worker_tests.cpp
• tests/unit/server/query_overlay_tests.cpp
• tests/unit/support/cache_store_tests.cpp

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fba8b75c78

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b7ebb115a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[coderabbitai]

🧹 Nitpick comments (1)

src/server/state/session.h (1)

140-148: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win

Consider caching preamble_in_sync() result in callers that iterate overlays.

compute_preamble_bound(text) re-scans the buffer on every call. Downstream usage in query.cpp invokes preamble_in_sync() inside a visit_pch_overlays lambda, which may call it once per overlay. Since the result is identical for a given session/text within a single query, the repeated scans are redundant.

If the lambda is indeed invoked multiple times per query, consider hoisting the check out of the loop:

bool in_sync = !session.ast_dirty && session.preamble_in_sync();
visit_pch_overlays(
    [&](std::uint32_t id, const Session& session, const index::PreambleState& state) {
        if(!in_sync)
            return true;
        // ...
    });

This is a minor performance concern — preamble scanning is typically O(preamble size) which is small — but worth verifying if queries are high-frequency.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/server/state/session.h` around lines 140 - 148, The overlay query path
should avoid recomputing preamble synchronization for every overlay. In the
caller’s `visit_pch_overlays` flow, evaluate `session.preamble_in_sync()` once
before entering the lambda, combined with the existing `ast_dirty` condition,
and have the lambda reuse that cached result while preserving current behavior
for out-of-sync sessions.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/server/state/session.h`:
- Around line 140-148: The overlay query path should avoid recomputing preamble
synchronization for every overlay. In the caller’s `visit_pch_overlays` flow,
evaluate `session.preamble_in_sync()` once before entering the lambda, combined
with the existing `ast_dirty` condition, and have the lambda reuse that cached
result while preserving current behavior for out-of-sync sessions.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 021b08f3-109a-4e47-90ed-136777ce39b7

📥 Commits

Reviewing files that changed from the base of the PR and between acc3794 and 3c6b68c.

📒 Files selected for processing (6)

• src/index/preamble_state.h
• src/server/compiler/compiler.cpp
• src/server/service/feature_router.cpp
• src/server/service/query.cpp
• src/server/state/session.h
• src/server/state/workspace.cpp

🚧 Files skipped from review as they are similar to previous changes (5)

• src/server/compiler/compiler.cpp
• src/index/preamble_state.h
• src/server/state/workspace.cpp
• src/server/service/feature_router.cpp
• src/server/service/query.cpp

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: acc3794279

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec9c70af8f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: debffc13c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea0a599b49

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f07df4bb14

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d8076b93a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f2b9c41cd3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02e2e7c4f8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".