Repository navigation
docs: v1.0 changelog and align guides with actual behavior - #495
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughDocumentation-only update across English and Chinese docs: adds a v1.0.0 changelog (new Chinese translation included), revises design docs on invalidation/dirty-marking and server module layering (state/compiler/service/transport), updates configuration guide (worker counts, cache dir, tracker polling), corrects editors guide commands, and trims clice.toml comments. ChangesDocumentation updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0405f43d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Prepares the documentation side of the v1.0 release: a real feature changelog, and a pass over the guides and design docs to make them match what the server actually does today. English and Chinese are kept in lockstep; the Chinese changelog directory is new.
Changelog
docs/{en,zh}/changelog/feature-changelog.mdgains the v1.0.0 entry: everything user-visible since the v0.1.0-alpha series, grouped into architecture, compilation contexts, LSP surface, indexing, modules, caching, configuration, tooling API, editor extensions, and operability. Breaking changes and upgrade caveats (config file location, key rename, one-time cache/index rebuild, LLVM 21.1.8 baseline) are called out, and a "Known gaps" section keeps the claims honest (partial features, no code actions, clang-tidy unwired).Configuration guide vs. reality
project.index_dir(the key does not exist; index artifacts live in the unified cache undercache_dir).[tracker]section (poll intervals, 0 disables) andmin/max_stateless_worker_count.clice.toml, then.clice/config.toml),initializationOptionsoverriding the file with defaults applied after the merge, and the fact that config changes require a server restart (no hot reload).max_active_file, memory-based worker restarts); it now carries the same "not yet wired/enforced" caveats as the English page.docs/clice.tomlno longer advertises${version}/${llvm_version}substitution variables that never existed.Editors guide
clice serversubcommand; it isclice serve.build/is not special-cased).Design docs
design/overview.md: thesrc/server/section described a layout that no longer exists (workspace/,MasterServerunderservice/). Rewritten to the actual six directories (protocol/,state/,compiler/,service/,transport/,worker/), including the invalidation engine and the stat-polling file tracker.design/incremental-parse.md: external changes are now discovered proactively by the file tracker (the two-layer check remains as the backstop), and two "known limitations" that have since been implemented (compile flags in the PCH cache key, shared cache metadata) are removed; the content-addressing description reflects the flag-aware key.Out of scope, noted for follow-up
editors/vscode/package.jsondeclares a deadclice-client.trace.serverkey (the client id isclice) and a socket-mode port default that doesn't match the server's; these are extension-code fixes, not docs.design/multi-process.mduses pre-refactor terms for the master's state management in two conceptual sentences; judged non-misleading (no file paths involved).Summary by CodeRabbit