Repository navigation
feat: add integration tests for xmake - #158
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds integration tests for xmake build system by implementing the previously commented-out integration_tests target. The changes include adding CI-specific configuration to handle platform differences, particularly for macOS environments where Python package management behaves differently.
Key changes:
- Uncommented and enhanced the integration_tests target with improved Python dependency handling
- Added a new "ci" configuration option to handle CI-specific behavior
- Updated GitHub Actions workflow to enable the CI configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| xmake.lua | Added CI option, implemented integration_tests target with platform-specific Python handling |
| .github/workflows/xmake.yml | Enabled CI configuration flag in the xmake workflow |
16bit-ykiko
changed the title
16bit-ykiko
added a commit
that referenced
this pull request
Jun 7, 2026
Update kotatsu to ea7d99b which fixes cancel propagation for reentrantly-cancelled tasks (#158, #160). Use when_any-based structured shutdown so all tasks are properly cancelled before cleanup, avoiding ASAN use-after-free on exit. Add close_peer_on_shutdown workaround for pipe mode: the sentinel prevents cancel from reaching pending I/O when shutdown fires inline from peer.run()'s exit handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.