Only successful installs should be cached

Make sure not to leave inconsistent data behind. If the install failed, delete the pacakge dir, and the JSON cache
clibs · Nov 18, 2022 · 90114c2 · 90114c2
1 parent a080927
commit 90114c2
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/common/clib-package.c b/src/common/clib-package.c
@@ -1578,8 +1578,10 @@ int clib_package_install(clib_package_t *pkg, const char *dir, int verbose) {
 
 cleanup:
   if (pkg_dir) {
-    rimraf(pkg_dir);
-    _debug("deleted inconsistent package dir: %s", pkg_dir);
+    if (0 != rc) {
+      rimraf(pkg_dir);
+      _debug("deleted inconsistent package dir: %s", pkg_dir);
+    }
 
     free(pkg_dir);
   }