chore: replace deprecated DEFAULT_FILE_STORAGE - #98
Merged
Conversation
kaustavb12
force-pushed
the
kaustav/remove_storage_settings
branch
from
September 7, 2025 08:18
690335a to
aea548b
Compare
Replaces `DEFAULT_FILE_STORAGE` which was deprecated in Django 4.2 with STORAGES['default']['BACKEND'] in-line with changes in edx-platform
kaustavb12
force-pushed
the
kaustav/remove_storage_settings
branch
from
September 7, 2025 08:26
aea548b to
621193a
Compare
kdmccormick
approved these changes
Sep 8, 2025
kdmccormick
left a comment
kdmccormick
left a comment
There was a problem hiding this comment.
Thanks!
For reference, from the edx-platform side, we didn't mean for this to go out as a breaking change, but it did: openedx/openedx-platform#37333
Contributor
Author
|
Thanks @kdmccormick @mrtmm @fghaas Can you please help with the review and merge of this PR. :) |
mrtmm
self-requested a review
September 12, 2025 08:41
mrtmm
approved these changes
Sep 12, 2025
mrtmm
left a comment
mrtmm
left a comment
There was a problem hiding this comment.
Thanks for the PR @kaustavb12, looks good to me!
|
Version |
Contributor
Author
|
@mrtmm Thanks a lot for the review and merge. Noted about the tag and branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
openedx/openedx-platform#37002 replaced
DEFAULT_FILE_STORAGEfrom edx-platform.This PR does the same for tutor-contrib-s3; otherwise, instance deployments fails with the error:
closes #97
cc. @kdmccormick
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Deploy this branch to a sandbox with the latest master branch of edx-platform and verify that it deploys without any errors and that file uploads/reports work correctly.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Private Ref : BB-10021