Skip to content

fix(shared): Fix link typedoc error #7251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wobsoriano merged 3 commits into from
Nov 18, 2025
+2 −3
Merged

fix(shared): Fix link typedoc error #7251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acb2700
Fix link typedoc error
SarahSoutoul Nov 18, 2025
14da6d9
Add changeset
SarahSoutoul Nov 18, 2025
6420482
Merge branch 'main' into ss/fix-link-typedoc
SarahSoutoul Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/green-roses-decide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
Comment on lines +1 to +2
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Changeset file is incomplete and will fail validation.

The changeset file must declare which package(s) were changed and the bump type (patch/minor/major) between the --- delimiters. The current file contains only empty delimiters.

Based on the PR title mentioning "fix(shared)", the changeset should declare the @clerk/shared package.

Apply this diff to add the required package declaration:

 ---
---
+@clerk/shared: patch
+"Fix link typedoc error"
+---

Note: Replace patch with minor or major if appropriate for your versioning strategy.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In .changeset/green-roses-decide.md around lines 1 to 2, the changeset is empty
and will fail validation; update the section between the '---' delimiters to
declare the changed package and bump type by adding an entry for @clerk/shared
with the desired release level (e.g., patch), for example replace the empty
content with a YAML block listing the package name and "patch" (or
"minor"/"major" if appropriate) so the file contains the required package
declaration and version bump type.

3 changes: 0 additions & 3 deletions packages/shared/src/errors/clerkApiResponseError.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ interface ClerkAPIResponseOptions extends Omit<ClerkErrorParams, 'message' | 'co
retryAfter?: number;
}

/**
* Class representing a Clerk API Response Error.
*/
export class ClerkAPIResponseError extends ClerkError implements ClerkAPIResponseErrorInterface {
Copy link
Contributor

@NWylynko NWylynko Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you specifically not want this class to be included in the typedoc output?

Copy link
Contributor Author

@SarahSoutoul SarahSoutoul Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's already being outputted, so there was a duplication. This comment was added as part of my work, but realized it caused the duplication.

Copy link
Contributor Author

@SarahSoutoul SarahSoutoul Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context here: clerk/clerk-docs#2649 (comment)

Copy link
Contributor Author

@SarahSoutoul SarahSoutoul Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two ClerkAPIResponseError. @NWylynko

Screenshot 2025-11-18 at 11 00 27 am Screenshot 2025-11-18 at 11 00 19 am

static kind = 'ClerkAPIResponseError';
status: number;
Expand Down
Loading