-
Notifications
You must be signed in to change notification settings - Fork 419
refactor(clerk-js): Ensure last used badge does not show with a single strategy #7224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexcarpenter
merged 9 commits into
main
from
alexcarpenter/user-3976-last-used-strategy-should-not-render-if-there-is-only-1
Nov 18, 2025
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9e330d2
init
alexcarpenter 45437aa
add tests
alexcarpenter 7cc7508
Merge branch 'main' into alexcarpenter/user-3976-last-used-strategy-s…
alexcarpenter 2e4b99d
Update useTotalEnabledAuthMethods.ts
alexcarpenter a4ee67b
Merge branch 'alexcarpenter/user-3976-last-used-strategy-should-not-r…
alexcarpenter 6d302cb
return the count
alexcarpenter 46ee462
Merge branch 'main' into alexcarpenter/user-3976-last-used-strategy-s…
alexcarpenter 1fcd647
add changeset
alexcarpenter 7387aa2
Merge branch 'alexcarpenter/user-3976-last-used-strategy-should-not-r…
alexcarpenter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
packages/clerk-js/src/ui/hooks/useTotalEnabledAuthMethods.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import type { Attribute } from '@clerk/shared/types'; | ||
|
|
||
| import { useEnvironment } from '../contexts/EnvironmentContext'; | ||
| import { useEnabledThirdPartyProviders } from './useEnabledThirdPartyProviders'; | ||
|
|
||
| export const useTotalEnabledAuthMethods = (): { totalCount: number } => { | ||
| const { userSettings } = useEnvironment(); | ||
| const { authenticatableOauthStrategies, web3Strategies, alternativePhoneCodeChannels } = | ||
| useEnabledThirdPartyProviders(); | ||
|
|
||
| const firstFactorCount = userSettings.enabledFirstFactorIdentifiers.filter( | ||
| (attr: Attribute) => attr !== 'passkey', | ||
| ).length; | ||
|
|
||
| const oauthCount = authenticatableOauthStrategies.length; | ||
| const web3Count = web3Strategies.length; | ||
| const alternativePhoneCodeCount = alternativePhoneCodeChannels.length; | ||
|
|
||
| const totalCount = firstFactorCount + oauthCount + web3Count + alternativePhoneCodeCount; | ||
|
|
||
| return { totalCount }; | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you return this value as
totalEnabledAuthMethods, you won't have to rename it every time we use the hook.also since you're only returning one value you don't really need to wrap it in an object. However, if you prefer the object notation, I think this might be a little cleaner: