fix(clerk-js): Add private _create method for use inside runAsyncResourceTask

.changeset/purple-toys-refuse.md

@@ -0,0 +1,6 @@
+---
+'@clerk/clerk-js': minor
+'@clerk/types': minor
+---
+
+[Experimental] Fix issue where calling `this.create()` would not correctly propogate errors.

packages/clerk-js/src/core/resources/SignIn.ts

@@ -703,12 +703,16 @@ class SignInFuture implements SignInFutureResource {
     });
   }
 
+  private async _create(params: SignInFutureCreateParams): Promise<void> {
+    await this.resource.__internal_basePost({
+      path: this.resource.pathRoot,
+      body: params,
+    });
+  }
+
   async create(params: SignInFutureCreateParams): Promise<{ error: unknown }> {
     return runAsyncResourceTask(this.resource, async () => {
-      await this.resource.__internal_basePost({
-        path: this.resource.pathRoot,
-        body: params,
-      });
+      await this._create(params);
     });
   }
 
@@ -744,7 +748,7 @@ class SignInFuture implements SignInFutureResource {
 
     return runAsyncResourceTask(this.resource, async () => {
       if (emailAddress) {
-        await this.create({ identifier: emailAddress });
+        await this._create({ identifier: emailAddress });
       }
 
       const emailCodeFactor = this.selectFirstFactor({ strategy: 'email_code', emailAddressId });

packages/clerk-js/src/core/resources/SignUp.ts

@@ -660,20 +660,24 @@ class SignUpFuture implements SignUpFutureResource {
     return { captchaToken, captchaWidgetType, captchaError };
   }
 
-  async create(params: SignUpFutureCreateParams): Promise<{ error: unknown }> {
-    return runAsyncResourceTask(this.resource, async () => {
-      const { captchaToken, captchaWidgetType, captchaError } = await this.getCaptchaToken();
+  private async _create(params: SignUpFutureCreateParams): Promise<void> {
+    const { captchaToken, captchaWidgetType, captchaError } = await this.getCaptchaToken();
+
+    const body: Record<string, unknown> = {
+      transfer: params.transfer,
+      captchaToken,
+      captchaWidgetType,
+      captchaError,
+      ...params,
+      unsafeMetadata: params.unsafeMetadata ? normalizeUnsafeMetadata(params.unsafeMetadata) : undefined,
+    };
 
-      const body: Record<string, unknown> = {
-        transfer: params.transfer,
-        captchaToken,
-        captchaWidgetType,
-        captchaError,
-        ...params,
-        unsafeMetadata: params.unsafeMetadata ? normalizeUnsafeMetadata(params.unsafeMetadata) : undefined,
-      };
+    await this.resource.__internal_basePost({ path: this.resource.pathRoot, body });
+  }
 
-      await this.resource.__internal_basePost({ path: this.resource.pathRoot, body });
+  async create(params: SignUpFutureCreateParams): Promise<{ error: unknown }> {
+    return runAsyncResourceTask(this.resource, async () => {
+      await this._create(params);
     });
   }
 
@@ -808,7 +812,7 @@ class SignUpFuture implements SignUpFutureResource {
 
       // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       const web3Wallet = identifier || this.resource.web3wallet!;
-      await this.create({ web3Wallet, unsafeMetadata, legalAccepted });
+      await this._create({ web3Wallet, unsafeMetadata, legalAccepted });
       await this.resource.__internal_basePost({
         body: { strategy },
         action: 'prepare_verification',

packages/types/src/signUpFuture.ts

@@ -11,6 +11,9 @@ interface SignUpFutureAdditionalParams {
 }
 
 export interface SignUpFutureCreateParams extends SignUpFutureAdditionalParams {
+  emailAddress?: string;
+  phoneNumber?: string;
+  username?: string;
   transfer?: boolean;
   ticket?: string;
   web3Wallet?: string;