Skip to content

chore(clerk-js): Update notice when cancelling a trial #6582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
panteliselef merged 8 commits into from
Aug 20, 2025
Merged

chore(clerk-js): Update notice when cancelling a trial #6582

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3fc8bf9
chore(clerk-js): Update notice when cancelling a trial
panteliselef Aug 20, 2025
9e474a9
update message
panteliselef Aug 20, 2025
a6cea81
align locales
panteliselef Aug 20, 2025
4072f50
update test
panteliselef Aug 20, 2025
3034320
Apply suggestions from code review
panteliselef Aug 20, 2025
05df68f
Merge remote-tracking branch 'origin/elef/bill-1180-trial-cancellatio…
panteliselef Aug 20, 2025
6982655
format
panteliselef Aug 20, 2025
ba2f317
format
panteliselef Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/afraid-waves-bow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@clerk/localizations': minor
'@clerk/types': minor
'@clerk/clerk-js': patch
---

[Billing Beta] Rename `cancelFreeTrialDescription` to `cancelFreeTrialAccessUntil`.
5 changes: 5 additions & 0 deletions .changeset/thick-frogs-hope.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Update notice when cancelling a trial.
2 changes: 1 addition & 1 deletion ...ges/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1214,7 +1214,7 @@ describe('SubscriptionDetails', () => {
expect(getByText('Cancel free trial for Pro Plan plan?')).toBeVisible();
expect(
getByText(
'You’re about to cancel your free trial for the Pro Plan plan. If you cancel now, you’ll lose access to the plan’s features right away and won’t be able to start the trial again.',
'Your Pro Plan trial will remain active until February 1, 2021. After that, you will no longer have access and no charges will apply.',
),
).toBeVisible();
expect(getByText('Keep free trial')).toBeVisible();
Expand Down
3 changes: 2 additions & 1 deletion packages/clerk-js/src/ui/components/SubscriptionDetails/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,9 @@ const SubscriptionDetailsFooter = withCardStateProvider(() => {
colorScheme='secondary'
localizationKey={
selectedSubscription?.isFreeTrial
? localizationKeys('commerce.cancelFreeTrialDescription', {
? localizationKeys('commerce.cancelFreeTrialAccessUntil', {
plan: selectedSubscription.plan.name,
date: selectedSubscription.periodEnd as Date,
})
: selectedSubscription.status === 'upcoming'
? localizationKeys('commerce.cancelSubscriptionNoCharge')
Expand Down
8 changes: 8 additions & 0 deletions packages/localizations/src/ar-SA.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ export const arSA: LocalizationResource = {
availableFeatures: undefined,
billedAnnually: undefined,
billedMonthlyOnly: undefined,
cancelFreeTrial: undefined,
cancelFreeTrialAccessUntil: undefined,
cancelFreeTrialTitle: undefined,
cancelSubscription: undefined,
cancelSubscriptionAccessUntil: undefined,
cancelSubscriptionNoCharge: undefined,
Expand Down Expand Up @@ -109,6 +112,7 @@ export const arSA: LocalizationResource = {
defaultFreePlanActive: undefined,
free: undefined,
getStarted: undefined,
keepFreeTrial: undefined,
keepSubscription: undefined,
manage: undefined,
manageSubscription: undefined,
Expand Down Expand Up @@ -145,12 +149,16 @@ export const arSA: LocalizationResource = {
beginsOn: undefined,
currentBillingCycle: undefined,
endsOn: undefined,
firstPaymentAmount: undefined,
firstPaymentOn: undefined,
nextPaymentAmount: undefined,
nextPaymentOn: undefined,
pastDueAt: undefined,
renewsAt: undefined,
subscribedOn: undefined,
title: undefined,
trialEndsOn: undefined,
trialStartedOn: undefined,
},
subtotal: undefined,
switchPlan: undefined,
Expand Down
8 changes: 8 additions & 0 deletions packages/localizations/src/be-BY.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ export const beBY: LocalizationResource = {
availableFeatures: undefined,
billedAnnually: undefined,
billedMonthlyOnly: undefined,
cancelFreeTrial: undefined,
cancelFreeTrialAccessUntil: undefined,
cancelFreeTrialTitle: undefined,
cancelSubscription: undefined,
cancelSubscriptionAccessUntil: undefined,
cancelSubscriptionNoCharge: undefined,
Expand Down Expand Up @@ -109,6 +112,7 @@ export const beBY: LocalizationResource = {
defaultFreePlanActive: undefined,
free: undefined,
getStarted: undefined,
keepFreeTrial: undefined,
keepSubscription: undefined,
manage: undefined,
manageSubscription: undefined,
Expand Down Expand Up @@ -145,12 +149,16 @@ export const beBY: LocalizationResource = {
beginsOn: undefined,
currentBillingCycle: undefined,
endsOn: undefined,
firstPaymentAmount: undefined,
firstPaymentOn: undefined,
nextPaymentAmount: undefined,
nextPaymentOn: undefined,
pastDueAt: undefined,
renewsAt: undefined,
subscribedOn: undefined,
title: undefined,
trialEndsOn: undefined,
trialStartedOn: undefined,
},
subtotal: undefined,
switchPlan: undefined,
Expand Down
8 changes: 8 additions & 0 deletions packages/localizations/src/bg-BG.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ export const bgBG: LocalizationResource = {
availableFeatures: undefined,
billedAnnually: undefined,
billedMonthlyOnly: undefined,
cancelFreeTrial: undefined,
cancelFreeTrialAccessUntil: undefined,
cancelFreeTrialTitle: undefined,
Comment thread
panteliselef marked this conversation as resolved.
Outdated
cancelSubscription: undefined,
cancelSubscriptionAccessUntil: undefined,
cancelSubscriptionNoCharge: undefined,
Expand Down Expand Up @@ -109,6 +112,7 @@ export const bgBG: LocalizationResource = {
defaultFreePlanActive: undefined,
free: undefined,
getStarted: undefined,
keepFreeTrial: undefined,
keepSubscription: undefined,
manage: undefined,
manageSubscription: undefined,
Expand Down Expand Up @@ -145,12 +149,16 @@ export const bgBG: LocalizationResource = {
beginsOn: undefined,
currentBillingCycle: undefined,
endsOn: undefined,
firstPaymentAmount: undefined,
firstPaymentOn: undefined,
nextPaymentAmount: undefined,
Comment on lines +153 to 155

@coderabbitai coderabbitai Bot Aug 20, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Fill in subscriptionDetails “first payment” translations and confirm placeholder names

These are newly introduced keys and currently undefined. Propose adding friendly BG strings and mirroring en-US placeholders. Please verify the exact placeholder names (likely amount and date) against en-US before merging.

Proposed translations:

-      firstPaymentAmount: undefined,
-      firstPaymentOn: undefined,
+      firstPaymentAmount: 'Сума на първото плащане: {{ amount }}',
+      firstPaymentOn: 'Първо плащане на {{ date | longDate(\'bg-BG\') }}',

Run this to confirm the base en-US placeholders for these keys and ensure we’re using the same param names:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

en="$(fd -a 'en-US.ts' | head -n 1 || true)"
bg="$(fd -a 'bg-BG.ts' | head -n 1 || true)"

if [[ -z "${en}" || -z "${bg}" ]]; then
  echo "en-US.ts or bg-BG.ts not found. Ensure packages/localizations/src/en-US.ts and bg-BG.ts exist."
  exit 0
fi

echo "Base (en-US) — relevant keys:"
rg -nC1 -e 'firstPayment(Amount|On)\b' "$en" || true

echo -e "\nBulgarian (bg-BG) — relevant keys:"
rg -nC1 -e 'firstPayment(Amount|On)\b' "$bg" || true

Length of output: 1007

Fill in Bulgarian translations for new subscriptionDetails keys

The en-US entries for firstPaymentAmount and firstPaymentOn are static labels (no placeholders), so the BG values should mirror them directly. In packages/localizations/src/bg-BG.ts (lines 153–155), update as follows:

-      firstPaymentAmount: undefined,
-      firstPaymentOn: undefined,
+      firstPaymentAmount: 'Сума на първото плащане',
+      firstPaymentOn: 'Първото плащане на',

-      nextPaymentAmount: undefined,
+      nextPaymentAmount: 'Сума на следващото плащане',

If these strings are actually rendered with dynamic values in code, switch to template syntax (e.g. {{ amount }} or date filters) to match the implementation.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
firstPaymentAmount: undefined,
firstPaymentOn: undefined,
nextPaymentAmount: undefined,
firstPaymentAmount: 'Сума на първото плащане',
firstPaymentOn: 'Първото плащане на',
nextPaymentAmount: 'Сума на следващото плащане',
🤖 Prompt for AI Agents 
In packages/localizations/src/bg-BG.ts around lines 153 to 155, the Bulgarian
translations for subscriptionDetails are empty; set firstPaymentAmount and
firstPaymentOn to the same static Bulgarian strings used in en-US (translate the
English labels into Bulgarian), and provide an appropriate Bulgarian translation
for nextPaymentAmount as well; if these keys are actually rendered with dynamic
values in code, replace the static text with template placeholders (e.g.,
{{amount}} or {{date}}) to match the implementation.

nextPaymentOn: undefined,
pastDueAt: undefined,
renewsAt: undefined,
subscribedOn: undefined,
title: undefined,
trialEndsOn: undefined,
trialStartedOn: undefined,
},
subtotal: undefined,
switchPlan: undefined,
Expand Down
8 changes: 8 additions & 0 deletions packages/localizations/src/bn-IN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ export const bnIN: LocalizationResource = {
availableFeatures: undefined,
billedAnnually: 'বার্ষিক হিসাবে বিল করা হয়',
billedMonthlyOnly: undefined,
cancelFreeTrial: undefined,
cancelFreeTrialAccessUntil: undefined,
cancelFreeTrialTitle: undefined,
cancelSubscription: undefined,
Comment thread
panteliselef marked this conversation as resolved.
Outdated
cancelSubscriptionAccessUntil: undefined,
cancelSubscriptionNoCharge: undefined,
Expand Down Expand Up @@ -109,6 +112,7 @@ export const bnIN: LocalizationResource = {
defaultFreePlanActive: undefined,
free: 'বিনামূল্যে',
getStarted: 'শুরু করুন',
keepFreeTrial: undefined,
keepSubscription: undefined,
manage: undefined,
manageSubscription: 'সদস্যতা পরিচালনা করুন',
Expand Down Expand Up @@ -145,12 +149,16 @@ export const bnIN: LocalizationResource = {
beginsOn: undefined,
currentBillingCycle: undefined,
endsOn: undefined,
firstPaymentAmount: undefined,
firstPaymentOn: undefined,
nextPaymentAmount: undefined,
nextPaymentOn: undefined,
pastDueAt: undefined,
renewsAt: undefined,
subscribedOn: undefined,
title: undefined,
trialEndsOn: undefined,
trialStartedOn: undefined,
},
subtotal: undefined,
switchPlan: 'এই প্ল্যানে পরিবর্তন করুন',
Expand Down
8 changes: 8 additions & 0 deletions packages/localizations/src/ca-ES.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ export const caES: LocalizationResource = {
availableFeatures: undefined,
billedAnnually: undefined,
billedMonthlyOnly: undefined,
cancelFreeTrial: undefined,
cancelFreeTrialAccessUntil: undefined,
cancelFreeTrialTitle: undefined,
cancelSubscription: undefined,
Comment thread
panteliselef marked this conversation as resolved.
Outdated
cancelSubscriptionAccessUntil: undefined,
cancelSubscriptionNoCharge: undefined,
Expand Down Expand Up @@ -109,6 +112,7 @@ export const caES: LocalizationResource = {
defaultFreePlanActive: undefined,
free: undefined,
getStarted: undefined,
keepFreeTrial: undefined,
keepSubscription: undefined,
manage: undefined,
manageSubscription: undefined,
Expand Down Expand Up @@ -145,12 +149,16 @@ export const caES: LocalizationResource = {
beginsOn: undefined,
currentBillingCycle: undefined,
endsOn: undefined,
firstPaymentAmount: undefined,
firstPaymentOn: undefined,
nextPaymentAmount: undefined,
nextPaymentOn: undefined,
pastDueAt: undefined,
renewsAt: undefined,
subscribedOn: undefined,
title: undefined,
trialEndsOn: undefined,
trialStartedOn: undefined,
},
subtotal: undefined,
switchPlan: undefined,
Expand Down
8 changes: 8 additions & 0 deletions packages/localizations/src/cs-CZ.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ export const csCZ: LocalizationResource = {
availableFeatures: 'Dostupné funkce',
billedAnnually: 'Fakturováno ročně',
billedMonthlyOnly: 'Fakturováno pouze měsíčně',
cancelFreeTrial: undefined,
cancelFreeTrialAccessUntil: undefined,
cancelFreeTrialTitle: undefined,
cancelSubscription: 'Zrušit předplatné',
cancelSubscriptionAccessUntil:
"Funkce '{{plan}}' můžete používat do {{ date | longDate('cs-CZ') }}, poté k nim ztratíte přístup.",
Expand Down Expand Up @@ -113,6 +116,7 @@ export const csCZ: LocalizationResource = {
defaultFreePlanActive: 'Aktuálně používáte bezplatný plán',
free: 'Zdarma',
getStarted: 'Začít',
keepFreeTrial: undefined,
keepSubscription: 'Ponechat předplatné',
manage: 'Spravovat',
manageSubscription: 'Spravovat předplatné',
Expand Down Expand Up @@ -149,12 +153,16 @@ export const csCZ: LocalizationResource = {
beginsOn: 'Začíná dne',
currentBillingCycle: 'Aktuální fakturační cyklus',
endsOn: 'Končí dne',
firstPaymentAmount: undefined,
firstPaymentOn: undefined,
nextPaymentAmount: 'Výše další platby',
nextPaymentOn: 'Další platba dne',
pastDueAt: 'Po splatnosti dne',
renewsAt: 'Obnovuje se dne',
subscribedOn: 'Předplaceno dne',
title: 'Předplatné',
trialEndsOn: undefined,
trialStartedOn: undefined,
},
subtotal: 'Mezisoučet',
switchPlan: 'Přepnout na tento plán',
Expand Down
8 changes: 8 additions & 0 deletions packages/localizations/src/da-DK.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ export const daDK: LocalizationResource = {
availableFeatures: undefined,
billedAnnually: undefined,
billedMonthlyOnly: undefined,
cancelFreeTrial: undefined,
cancelFreeTrialAccessUntil: undefined,
cancelFreeTrialTitle: undefined,
cancelSubscription: undefined,
cancelSubscriptionAccessUntil: undefined,
cancelSubscriptionNoCharge: undefined,
Expand Down Expand Up @@ -109,6 +112,7 @@ export const daDK: LocalizationResource = {
defaultFreePlanActive: undefined,
free: undefined,
getStarted: undefined,
keepFreeTrial: undefined,
keepSubscription: undefined,
manage: undefined,
manageSubscription: undefined,
Expand Down Expand Up @@ -145,12 +149,16 @@ export const daDK: LocalizationResource = {
beginsOn: undefined,
currentBillingCycle: undefined,
endsOn: undefined,
firstPaymentAmount: undefined,
firstPaymentOn: undefined,
nextPaymentAmount: undefined,
nextPaymentOn: undefined,
pastDueAt: undefined,
renewsAt: undefined,
subscribedOn: undefined,
title: undefined,
trialEndsOn: undefined,
trialStartedOn: undefined,
},
subtotal: undefined,
switchPlan: undefined,
Expand Down
8 changes: 8 additions & 0 deletions packages/localizations/src/de-DE.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ export const deDE: LocalizationResource = {
availableFeatures: 'Verfügbare Funktionen',
billedAnnually: 'Jährlich abgerechnet',
billedMonthlyOnly: 'Nur monatlich abgerechnet',
cancelFreeTrial: undefined,
cancelFreeTrialAccessUntil: undefined,
cancelFreeTrialTitle: undefined,
cancelSubscription: 'Abonnement kündigen',
cancelSubscriptionAccessUntil:
"Sie haben Zugriff auf '{{plan}}' Funktionen bis zum {{ date | longDate('de-DE') }}. Danach haben Sie keinen Zugriff mehr.",
Expand Down Expand Up @@ -112,6 +115,7 @@ export const deDE: LocalizationResource = {
defaultFreePlanActive: 'Sie nutzen aktuell den kostenlosen Plan.',
free: 'Kostenlos',
getStarted: 'Jetzt starten',
keepFreeTrial: undefined,
keepSubscription: 'Abonnement behalten',
manage: 'Verwalten',
manageSubscription: 'Mitgliedschaft verwalten',
Expand Down Expand Up @@ -148,12 +152,16 @@ export const deDE: LocalizationResource = {
beginsOn: undefined,
currentBillingCycle: undefined,
endsOn: undefined,
firstPaymentAmount: undefined,
firstPaymentOn: undefined,
nextPaymentAmount: undefined,
nextPaymentOn: undefined,
pastDueAt: undefined,
renewsAt: undefined,
subscribedOn: undefined,
title: undefined,
trialEndsOn: undefined,
trialStartedOn: undefined,
},
subtotal: 'Zwischensumme',
switchPlan: 'Zu diesem Plan wechseln',
Expand Down
8 changes: 8 additions & 0 deletions packages/localizations/src/el-GR.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ export const elGR: LocalizationResource = {
availableFeatures: undefined,
billedAnnually: undefined,
billedMonthlyOnly: undefined,
cancelFreeTrial: undefined,
cancelFreeTrialAccessUntil: undefined,
cancelFreeTrialTitle: undefined,
cancelSubscription: undefined,
cancelSubscriptionAccessUntil: undefined,
cancelSubscriptionNoCharge: undefined,
Expand Down Expand Up @@ -109,6 +112,7 @@ export const elGR: LocalizationResource = {
defaultFreePlanActive: undefined,
free: undefined,
getStarted: undefined,
keepFreeTrial: undefined,
keepSubscription: undefined,
manage: undefined,
manageSubscription: undefined,
Expand Down Expand Up @@ -145,12 +149,16 @@ export const elGR: LocalizationResource = {
beginsOn: undefined,
currentBillingCycle: undefined,
endsOn: undefined,
firstPaymentAmount: undefined,
firstPaymentOn: undefined,
nextPaymentAmount: undefined,
nextPaymentOn: undefined,
pastDueAt: undefined,
renewsAt: undefined,
subscribedOn: undefined,
title: undefined,
trialEndsOn: undefined,
trialStartedOn: undefined,
},
subtotal: undefined,
switchPlan: undefined,
Expand Down
8 changes: 8 additions & 0 deletions packages/localizations/src/en-GB.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ export const enGB: LocalizationResource = {
availableFeatures: undefined,
billedAnnually: undefined,
billedMonthlyOnly: undefined,
cancelFreeTrial: undefined,
cancelFreeTrialAccessUntil: undefined,
cancelFreeTrialTitle: undefined,
cancelSubscription: undefined,
cancelSubscriptionAccessUntil: undefined,
cancelSubscriptionNoCharge: undefined,
Expand Down Expand Up @@ -109,6 +112,7 @@ export const enGB: LocalizationResource = {
defaultFreePlanActive: undefined,
free: undefined,
getStarted: undefined,
keepFreeTrial: undefined,
keepSubscription: undefined,
manage: undefined,
manageSubscription: undefined,
Expand Down Expand Up @@ -145,12 +149,16 @@ export const enGB: LocalizationResource = {
beginsOn: undefined,
currentBillingCycle: undefined,
endsOn: undefined,
firstPaymentAmount: undefined,
firstPaymentOn: undefined,
nextPaymentAmount: undefined,
nextPaymentOn: undefined,
pastDueAt: undefined,
renewsAt: undefined,
subscribedOn: undefined,
title: undefined,
trialEndsOn: undefined,
trialStartedOn: undefined,
},
subtotal: undefined,
switchPlan: undefined,
Expand Down
Loading
Loading