-
Notifications
You must be signed in to change notification settings - Fork 418
chore(nextjs,vue,nuxt): Export RedirectToTasks control component
#6546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@clerk/nextjs': patch | ||
| '@clerk/vue': patch | ||
| '@clerk/nuxt': patch | ||
| --- | ||
|
|
||
| Fix export of `RedirectToTasks` control component |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,7 @@ export { | |
| RedirectToSignIn, | ||
| RedirectToSignUp, | ||
| RedirectToUserProfile, | ||
| RedirectToTasks, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainLGTM: Nuxt re-export of RedirectToTasks from @clerk/vue is consistent. This mirrors the Vue export and keeps the tree-shakable named export pattern. Please confirm dependency alignment so Nuxt consumes a
Run this script to check dependency alignment and presence across packages: If helpful, I can also prepare a tiny import test to assert 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "1) Confirm nuxt re-exports RedirectToTasks only once"
rg -n 'RedirectToTasks' packages/nuxt/src/runtime/components/index.ts
echo "2) Check that @clerk/nuxt depends on @clerk/vue at an appropriate version"
NUXT_PKG=$(fd -a '^package\.json$' packages/nuxt | head -n1)
if [ -n "$NUXT_PKG" ]; then
echo "Found package file: $NUXT_PKG"
if command -v jq >/dev/null 2>&1; then
jq -r '
{
dependencies: (.dependencies["@clerk/vue"] // null),
peerDependencies: (.peerDependencies["@clerk/vue"] // null),
devDependencies: (.devDependencies["@clerk/vue"] // null)
}' "$NUXT_PKG"
else
rg -n '"@clerk/vue":' "$NUXT_PKG" || true
fi
else
echo "Could not find packages/nuxt package.json" >&2
fi
echo "3) Ensure Vue index includes RedirectToTasks"
rg -n 'RedirectToTasks' packages/vue/src/components/index.ts || true
echo "4) Locate changeset mentioning RedirectToTasks"
fd -a '\.changeset/.*\.md' | xargs -r rg -n 'RedirectToTasks|@clerk/vue|@clerk/nuxt'Length of output: 1441 Confirm dependency alignment and add missing changeset All checks pass on the re-export, but there’s no recorded changeset for this new export. • packages/nuxt/src/runtime/components/index.ts Next steps:
🤖 Prompt for AI Agents |
||
| AuthenticateWithRedirectCallback, | ||
| RedirectToCreateOrganization, | ||
| RedirectToOrganizationProfile, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,7 @@ export { | |
| RedirectToSignIn, | ||
| RedirectToSignUp, | ||
| RedirectToUserProfile, | ||
| RedirectToTasks, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainLGTM: Added RedirectToTasks export is correct and tree-shake friendly. Placement is consistent with other control components and maintains the existing export style. Please verify the source symbol exists and that consumers get proper typings.
Run this script to verify the source export and look for potential cycles: If you want, I can draft a minimal smoke test that imports 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "1) Ensure Vue controlComponents exports RedirectToTasks"
fd -a -t f 'controlComponents(\.ts|/index\.ts)?$' packages/vue 2>/dev/null | tee /tmp/cc_files.txt
if [ ! -s /tmp/cc_files.txt ]; then
echo "Could not find controlComponents file(s) in packages/vue" >&2
fi
rg -n 'export\s+\{[^}]*RedirectToTasks|export\s+(const|function|class)\s+RedirectToTasks' $(cat /tmp/cc_files.txt) || true
echo "2) Ensure Vue components index re-exports RedirectToTasks"
rg -n 'RedirectToTasks' packages/vue/src/components/index.ts || true
echo "3) Quick cycle smell: controlComponents importing components index"
rg -n "from ['\"]\./components['\"]" packages/vue/src || trueLength of output: 323 I’ve updated the verification script to avoid using 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "1) Locate Vue controlComponents file(s)"
files=$(fd -t f -e ts -- 'controlComponents(\.ts|/index\.ts)?$' packages/vue 2>/dev/null)
if [[ -z "$files" ]]; then
echo "✖ Could not find any controlComponents file(s) under packages/vue" >&2
else
echo "Found:"
echo "$files"
echo
echo "Searching for RedirectToTasks export in those files:"
rg -n 'export\s+\{[^}]*RedirectToTasks|export\s+(const|function|class)\s+RedirectToTasks' $files || true
fi
echo
echo "2) Verify re-export in components index.ts"
rg -n 'RedirectToTasks' packages/vue/src/components/index.ts || true
echo
echo "3) Quick cycle check: controlComponents → components index"
rg -n "from ['\"]\./components['\"]" packages/vue/src || trueLength of output: 1184 I’ll check whether there’s a JSDoc block immediately above the 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "Inspecting context around RedirectToTasks export for JSDoc:"
rg -n -C3 'export\s+const\s+RedirectToTasks' packages/vue/src/components/controlComponents.ts || trueLength of output: 414 Add public JSDoc for RedirectToTasks and consider a smoke test
🤖 Prompt for AI Agents |
||
| AuthenticateWithRedirectCallback, | ||
| RedirectToCreateOrganization, | ||
| RedirectToOrganizationProfile, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Verify the source module actually exports RedirectToTasks
Ensure
./client-boundary/controlComponentsprovides a named exportRedirectToTasks(and no duplicate re-exports elsewhere) to avoid runtime/import errors.Run this script to confirm:
🏁 Script executed:
Length of output: 1095
Missing
RedirectToTasksExport incontrolComponentsThe re-export in
packages/nextjs/src/index.tsreferences aRedirectToTaskssymbol that isn’t defined or exported in./client-boundary/controlComponents. This will cause a runtime import error.• Location of broken re-export:
RedirectToTasks, … } from './client-boundary/controlComponents';)Action required:
export(function, class, or const) forRedirectToTasksinpackages/nextjs/src/client-boundary/controlComponents, or🤖 Prompt for AI Agents