-
Notifications
You must be signed in to change notification settings - Fork 419
chore(repo): Group related machine auth tests #6524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a9787ef
dc8c7be
58191b1
1707c12
56867b2
757ea76
dc77a3f
ebff149
4f0bd61
ebd8b96
398c3cf
7fad6ca
48bc893
2fa0b44
98b79d7
91a7e56
c224d6f
b52c3b9
45a490d
268c92b
8807419
2dff52b
b628254
f3837b1
630410f
8f4f54a
aa7b09b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| --- | ||
| --- | ||
|
Comment on lines
+1
to
+2
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Invalid/empty Changeset frontmatter will break the Changesets pipeline The file only contains an empty frontmatter block ( Action:
Example template (replace PACKAGE_NAME with actual workspace package names): ---
'PACKAGE_NAME': none
---
chore(repo): Group related machine auth testsI can help enumerate workspace package names to fill this properly if needed. 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -7,7 +7,7 @@ import { appConfigs } from '../../presets'; | |||||
| import type { FakeAPIKey, FakeUser } from '../../testUtils'; | ||||||
| import { createTestUtils } from '../../testUtils'; | ||||||
|
|
||||||
| test.describe('Next.js API key auth within clerkMiddleware() @nextjs', () => { | ||||||
| test.describe('Next.js API key auth within clerkMiddleware() @machine', () => { | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainSwitched tag to @machine — ensure tag-based runners are updated The suite label now ends with "@machine". If your CI or dev tooling filters by tags (e.g., to shard or selectively run tests), update those filters accordingly. Consider tagging related suites consistently for easier targeting (e.g., also tagging Next.js-specific cases with @machine if they belong to the same group). Run this to audit tag usage patterns in this file and related tests: 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "Tags in this file:"
rg -n --hidden -S "@[a-zA-Z0-9_-]+" integration/tests/machine-auth/api-keys.test.ts
echo
echo "All '@machine' test labels across machine-auth tests:"
rg -n --hidden -S "@machine" integration/tests/machine-authLength of output: 1249 Align test suite tagging for consistent filtering There are two suites in
If you want Next.js–specific machine-auth tests to run when filtering by • File: integration/tests/machine-auth/api-keys.test.ts Suggested diff: -test.describe('Next.js API key auth within routes @nextjs', () => {
+test.describe('Next.js API key auth within routes @nextjs @machine', () => {📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| test.describe.configure({ mode: 'parallel' }); | ||||||
| let app: Application; | ||||||
| let fakeUser: FakeUser; | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Empty Changeset is likely non-actionable and may confuse/impact the release workflow
This file only contains YAML front matter delimiters with no package bumps or summary. Depending on your Changesets setup, this can either be ignored or cause CI confusion. For test-only/grouping changes, prefer either removing the changeset entirely or adding a proper bump if a release is intended.
Run the following to inspect repo configs and references to the Changesets workflow to ensure an empty changeset is acceptable here:
🏁 Script executed:
Length of output: 14405
Clarify Intent for This Empty Changeset
This file is an intentionally empty changeset (just the
---front-matter) created bypnpm changeset:empty. Per our CONTRIBUTING guide, empty changesets are supported as an “escape hatch” for internal refactors or test-only PRs and will not generate any changelog entries.• If you intended not to produce a release or changelog entry, no further action is needed.
• If you do want to publish changes, update this file’s front-matter to list the affected package(s), bump type (patch/minor/major), and add a brief summary.
🤖 Prompt for AI Agents