Skip to content

fix(clerk-js): Allow modal closing after a new connected account #6433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacekradko merged 2 commits into from
Jul 30, 2025
Merged

fix(clerk-js): Allow modal closing after a new connected account #6433

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8e65eb
add defensive check for typeof modal being an object
jacekradko Jul 29, 2025
b31e766
changeset
jacekradko Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/clerk-js/src/ui/Components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ const Components = (props: ComponentsProps) => {
setState(s => {
function handleCloseModalForExperimentalUserVerification() {
const modal = s[`${name}Modal`] || {};
if ('afterVerificationCancelled' in modal && notify) {
if (modal && typeof modal === 'object' && 'afterVerificationCancelled' in modal && notify) {
modal.afterVerificationCancelled?.();
}
}
Expand Down
Loading