-
Notifications
You must be signed in to change notification settings - Fork 419
feat(clerk-js,clerk-react,nextjs): Introduce <TaskSelectOrganization /> component
#6376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7f92d37
Introduce separate context
LauraBeatris 3a707e5
Add props types and mount methods
LauraBeatris de2a2bc
Add changeset
LauraBeatris f100035
Display error in development if orgs is disabled
LauraBeatris 1ec8cd1
Update snapshot for public exports
LauraBeatris 1fef012
refactor: Use `OrganizationList` but without revalidating in place
LauraBeatris d2074f6
Export `TaskSelectOrganization` from `@clerk/nextjs`
LauraBeatris acac882
Add guard for active session
LauraBeatris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- | ||
| '@clerk/clerk-js': minor | ||
| --- | ||
|
|
||
| Introduce `<TaskSelectOrganization />` component. | ||
|
|
||
| It allows you to eject the organization selection task flow from the default `SignIn` and `SignUp` components and render it on custom URL paths using `taskUrls`. | ||
|
|
||
| Usage example: | ||
| ```tsx | ||
| <ClerkProvider taskUrls={{ 'select-organization': '/onboarding/select-organization' }}> | ||
| <App /> | ||
| </ClerkProvider> | ||
| ``` | ||
|
|
||
| ```tsx | ||
| function OnboardingSelectOrganization() { | ||
| return <TaskSelectOrganization redirectUrlComplete="/dashboard/onboarding-complete" /> | ||
| } | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@clerk/types': patch | ||
| --- | ||
|
|
||
| Add TypeScript types for `<TaskSelectOrganization />` component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, I've rewritten the entire
OrganizationListlogic withinTaskSelectOrganizationto avoid a flicker of UI on revalidation of memberships.As I started to export
TaskSelectOrganizationas a public component, I realized that it couldn't receive a custom appearance forOrganizationList.Simpler solution is just to not revalidate the data in place when resolving a
select-organizationtask.