Skip to content

refactor(clerk-js): Use min height vs empty element for UserProfile #6363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcarpenter merged 4 commits into from
Jul 21, 2025
Merged

refactor(clerk-js): Use min height vs empty element for UserProfile #6363

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d801902
refactor(clerk-js): Use min height vs empty element for UserProfile
alexcarpenter Jul 21, 2025
0ff3a0d
add changeset
alexcarpenter Jul 21, 2025
519a0c0
Merge branch 'main' into alexcarpenter/user-preview-avatar-space
alexcarpenter Jul 21, 2025
20f6ee3
Merge branch 'main' into alexcarpenter/user-preview-avatar-space
alexcarpenter Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions packages/clerk-js/src/ui/elements/UserPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,16 @@ export const UserPreview = (props: UserPreviewProps) => {
elementId={descriptors.userPreview.setId(elementId)}
align='center'
as='span'
sx={[t => ({ minWidth: '0px', width: 'fit-content', gap: t.space.$4 }), sx]}
sx={[
t => ({
minWidth: '0px',
width: 'fit-content',
gap: t.space.$4,
// We reserve space for the avatar if it is not visible
minHeight: imageUrl && !showAvatar ? getAvatarSizes(t) : undefined,
}),
sx,
]}
{...rest}
>
{/*Do not attempt to render or reserve space based on height if image url is not defined*/}
Expand Down Expand Up @@ -122,18 +131,7 @@ export const UserPreview = (props: UserPreviewProps) => {
</Flex>
)}
</Flex>
) : (
// Reserve layout space when avatar is not visible
<Flex
elementDescriptor={descriptors.userPreviewAvatarContainer}
elementId={descriptors.userPreviewAvatarContainer.setId(elementId)}
justify='center'
as='span'
sx={t => ({
height: getAvatarSizes(t),
})}
/>
)
) : null
) : null}

<Flex
Expand Down
Loading