Skip to content

fix(localizations): Export esCR from the localizations package #6207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcarpenter merged 2 commits into from
Jun 30, 2025
Merged

fix(localizations): Export esCR from the localizations package #6207

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec85c9e
fix(localizations): Export esCR from the localizations package
beerose Jun 27, 2025
564caa4
fix: Include esCR in generate script and package's files
beerose Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/violet-clubs-grin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/localizations': patch
---

Include `esCR` in the package's exports
Copy link
Member

@alexcarpenter alexcarpenter Jun 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to add it to the generate file https://github.com/clerk/javascript/blob/main/packages/localizations/src/utils/generate.ts

Copy link
Contributor Author

@beerose beerose Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, missed that. Adding.

Copy link
Contributor Author

@beerose beerose Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also files section in package.json.

Copy link
Contributor Author

@beerose beerose Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if I can go ahead and merge or should I rather leave that to your team.

1 change: 1 addition & 0 deletions packages/localizations/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export { deDE } from './de-DE';
export { elGR } from './el-GR';
export { enUS } from './en-US';
export { enGB } from './en-GB';
export { esCR } from './es-CR';
export { esES } from './es-ES';
export { esMX } from './es-MX';
export { esUY } from './es-UY';
Expand Down
Loading