Skip to content

chore(testing): Update util waitForStipeElements to accept a state #6204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
panteliselef merged 2 commits into from
Jun 27, 2025
Merged

chore(testing): Update util waitForStipeElements to accept a state #6204

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3929d76
update `waitForStipeElements`
panteliselef Jun 27, 2025
099c591
Apply suggestions from code review
panteliselef Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eleven-days-sniff.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/testing': patch
---

Allow for `waitForStripeElements` helper to accept a `state` of `visible` or `hidden`.
4 changes: 3 additions & 1 deletion integration/tests/pricing-table.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,9 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withBilling] })('pricing tabl
});
await u.po.checkout.clickPayOrSubscribe();
await expect(u.po.page.locator('.cl-checkout-root').getByText('The card was declined.').first()).toBeVisible();
await u.po.checkout.waitForStipeElements();
// It should unmount and remount the payment element
await u.po.checkout.waitForStipeElements({ state: 'hidden' });
await u.po.checkout.waitForStipeElements({ state: 'visible' });
Comment thread
panteliselef marked this conversation as resolved.
Outdated
await u.po.checkout.fillTestCard();
await u.po.checkout.clickPayOrSubscribe();
await expect(u.po.page.locator('.cl-checkout-root').getByText('Payment was successful!')).toBeVisible();
Expand Down
7 changes: 2 additions & 5 deletions packages/testing/src/playwright/unstable/page-objects/checkout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,8 @@ export const createCheckoutPageObject = (testArgs: { page: EnhancedPage }) => {
await frame.getByLabel('Country').selectOption(card.country);
await frame.getByLabel('ZIP code').fill(card.zip);
},
waitForStipeElements: async () => {
return page
.frameLocator('iframe[src*="elements-inner-payment"]')
.getByLabel('Card number')
.waitFor({ state: 'visible' });
waitForStipeElements: async ({ state = 'visible' }: { state?: 'visible' | 'hidden' } = {}) => {
Comment thread
panteliselef marked this conversation as resolved.
Outdated
return page.frameLocator('iframe[src*="elements-inner-payment"]').getByLabel('Card number').waitFor({ state });
Comment thread
panteliselef marked this conversation as resolved.
Outdated
},
clickPayOrSubscribe: async () => {
await self.root.getByRole('button', { name: /subscribe|pay\s\$/i }).click();
Expand Down
Loading