-
Notifications
You must be signed in to change notification settings - Fork 419
chore(clerk-js, shared): Create experimental PaymentElement #6180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
3c59cf7
2d6d48b
cc91f08
240cca9
814e37a
d038eec
9899b0c
053b1e6
dddbb09
f9f4edb
ffe90af
860234e
2eb7bfb
a645207
ce930d0
2005c75
493e052
10be49d
0b407f7
aee12d0
41401b1
8769c58
c69e771
8ff115f
3d2c595
02d3552
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| '@clerk/clerk-js': minor | ||
| '@clerk/shared': minor | ||
| '@clerk/clerk-react': minor | ||
| '@clerk/types': minor | ||
| --- | ||
|
|
||
| wip | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ | |
| { "path": "./dist/ui-common*.js", "maxSize": "110KB" }, | ||
| { "path": "./dist/vendors*.js", "maxSize": "40.2KB" }, | ||
| { "path": "./dist/coinbase*.js", "maxSize": "38KB" }, | ||
| { "path": "./dist/stripe-vendors*.js", "maxSize": "5.54KB" }, | ||
| { "path": "./dist/createorganization*.js", "maxSize": "5KB" }, | ||
| { "path": "./dist/impersonationfab*.js", "maxSize": "5KB" }, | ||
| { "path": "./dist/organizationprofile*.js", "maxSize": "12KB" }, | ||
|
|
@@ -21,8 +22,7 @@ | |
| { "path": "./dist/waitlist*.js", "maxSize": "1.5KB" }, | ||
| { "path": "./dist/keylessPrompt*.js", "maxSize": "6.5KB" }, | ||
| { "path": "./dist/pricingTable*.js", "maxSize": "4.02KB" }, | ||
| { "path": "./dist/checkout*.js", "maxSize": "7.25KB" }, | ||
| { "path": "./dist/paymentSources*.js", "maxSize": "9.17KB" }, | ||
| { "path": "./dist/checkout*.js", "maxSize": "8.30KB" }, | ||
|
||
| { "path": "./dist/up-billing-page*.js", "maxSize": "3.0KB" }, | ||
| { "path": "./dist/op-billing-page*.js", "maxSize": "3.0KB" }, | ||
| { "path": "./dist/sessionTasks*.js", "maxSize": "1.5KB" } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -81,6 +81,7 @@ const common = ({ mode, variant, disableRHC = false }) => { | |
| * Necessary to prevent the Stripe dependencies from being bundled into | ||
| * SDKs such as Browser Extensions. | ||
| */ | ||
| // TODO: @COMMERCE: Do we still need this? | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @tmilewski do we need these to be set as external ? We are now stop using Also now don't import |
||
| externals: disableRHC ? ['@stripe/stripe-js', '@stripe/react-stripe-js'] : undefined, | ||
| optimization: { | ||
| splitChunks: { | ||
|
|
@@ -100,6 +101,11 @@ const common = ({ mode, variant, disableRHC = false }) => { | |
| name: 'coinbase-wallet-sdk', | ||
| chunks: 'all', | ||
| }, | ||
| stripeVendor: { | ||
| test: /[\\/]node_modules[\\/](@stripe\/stripe-js|@stripe\/react-stripe-js)[\\/]/, | ||
| name: 'stripe-vendors', | ||
| chunks: 'all', | ||
| }, | ||
| /** | ||
| * Sign up is shared between the SignUp component and the SignIn component. | ||
| */ | ||
|
|
@@ -108,17 +114,11 @@ const common = ({ mode, variant, disableRHC = false }) => { | |
| name: 'signup', | ||
| test: module => !!(module.resource && module.resource.includes('/ui/components/SignUp')), | ||
| }, | ||
| paymentSources: { | ||
| minChunks: 1, | ||
| name: 'paymentSources', | ||
| test: module => | ||
| !!( | ||
| module.resource && | ||
| (module.resource.includes('/ui/components/PaymentSources') || | ||
| // Include `@stripe/react-stripe-js` and `@stripe/stripe-js` in the checkout chunk | ||
| module.resource.includes('/node_modules/@stripe')) | ||
| ), | ||
| }, | ||
| // paymentSources: { | ||
| // minChunks: 1, | ||
| // name: 'paymentSources', | ||
| // test: module => !!(module.resource && module.resource.includes('/ui/components/PaymentSources')), | ||
| // }, | ||
| common: { | ||
| minChunks: 1, | ||
| name: 'ui-common', | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.