fix(clerk-react): IsomorphicClerk#addListener should return unsubscri…

…be method Issue: #1451
clerk · Jul 5, 2023 · f6b77a1 · f6b77a1
1 parent 50cea32
commit f6b77a1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/ninety-llamas-act.md b/.changeset/ninety-llamas-act.md
@@ -0,0 +1,5 @@
+---
+'@clerk/clerk-react': minor
+---
+
+Update IsomorphicClerk#addListener to correctly return an unsubscribe method
diff --git a/packages/react/src/isomorphicClerk.ts b/packages/react/src/isomorphicClerk.ts
@@ -10,16 +10,17 @@ import type {
   DomainOrProxyUrl,
   HandleMagicLinkVerificationParams,
   HandleOAuthCallbackParams,
+  ListenerCallback,
   OrganizationMembershipResource,
   OrganizationResource,
   RedirectOptions,
-  Resources,
   SetActiveParams,
   SignInProps,
   SignOut,
   SignOutCallback,
   SignOutOptions,
   SignUpProps,
+  UnsubscribeCallback,
   UserButtonProps,
   UserProfileProps,
   UserResource,
@@ -542,12 +543,14 @@ export default class IsomorphicClerk {
     }
   };
 
-  addListener = (listener: (emission: Resources) => void): void => {
+  addListener = (listener: ListenerCallback): UnsubscribeCallback => {
     const callback = () => this.clerkjs?.addListener(listener);
+
     if (this.clerkjs) {
-      callback();
+      return callback() as UnsubscribeCallback;
     } else {
       this.premountMethodCalls.set('addListener', callback);
+      return () => this.premountMethodCalls.delete('addListener');
     }
   };