Merged
Conversation
mauricioabreu
force-pushed
the
mauricio-antunes/bill-1226-update-go-sdk-with-billing-endpoints
branch
2 times, most recently
from
a80ceae to
1b5d4cf
Compare
Contributor
|
You also probably want to open this PR pointing to the |
paddycarver
reviewed
Sep 12, 2025
mauricioabreu
force-pushed
the
mauricio-antunes/bill-1226-update-go-sdk-with-billing-endpoints
branch
from
01c2f78 to
22831da
Compare
paddycarver
requested changes
Sep 23, 2025
Contributor
paddycarver
left a comment
paddycarver
left a comment
There was a problem hiding this comment.
I'm assuming those tests are following the pattern for other tests in this repo?
Contributor
Author
Yes, they are. |
paddycarver
reviewed
Sep 24, 2025
paddycarver
approved these changes
Sep 24, 2025
Contributor
paddycarver
left a comment
paddycarver
left a comment
There was a problem hiding this comment.
Type system nitpicks, feel free to use your judgment on whether to block on them or not.
| Object string `json:"object"` | ||
| ID string `json:"id"` | ||
| Name string `json:"name"` | ||
| Fee *BillingMoney `json:"fee"` |
Contributor
There was a problem hiding this comment.
Do we always have a Fee and only sometimes have an annual fee? Or are there times where we may not have a fee, like the default free plan? 🤔
Comment on lines
+101
to
+102
| Amount *BillingMoney `json:"amount"` | ||
| Date *int64 `json:"date"` |
Contributor
There was a problem hiding this comment.
Will these items ever not be set when the outer struct is present?
Co-authored-by: Paddy <paddy@carvers.com>
Co-authored-by: Paddy <paddy@carvers.com>
Co-authored-by: Paddy <paddy@carvers.com>
Co-authored-by: Paddy <paddy@carvers.com>
mauricioabreu
force-pushed
the
mauricio-antunes/bill-1226-update-go-sdk-with-billing-endpoints
branch
from
eb56983 to
1d64f3f
Compare
mauricioabreu
deleted the
mauricio-antunes/bill-1226-update-go-sdk-with-billing-endpoints
branch
mauricioabreu
restored the
mauricio-antunes/bill-1226-update-go-sdk-with-billing-endpoints
branch
mauricioabreu
deleted the
mauricio-antunes/bill-1226-update-go-sdk-with-billing-endpoints
branch
mauricioabreu
added a commit
that referenced
this pull request
Sep 25, 2025
* Add support for Billing endpoints * refactor: Rename commerce -> billing * fix: make PlanID nullable to support planless subs * refactor: remove unused struct * fix: we will be using PaymentMethod from now on * refactor: remove deprecated fields * refactor: remove deprecated invoice field * refactor: omitempty is useless when unmarshalling * refactor: query strings don't need omitempty * fix: several fix related to JSON tags * test: fix after struct changes * fix: Remove PayerType array * fix: we are not returning null features Co-authored-by: Paddy <paddy@carvers.com> * fix: we are not returning null plans Co-authored-by: Paddy <paddy@carvers.com> * fix: we are not returning null subscription items Co-authored-by: Paddy <paddy@carvers.com> * fix: we are not returning null plans Co-authored-by: Paddy <paddy@carvers.com> * fix: remove currency deprecated fields * test: fix * fix: period_start cannot be null --------- Co-authored-by: Paddy <paddy@carvers.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.