Skip to content

chore: Add docs on lightDark theme #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexcarpenter merged 9 commits into from
Jan 20, 2026
Merged

chore: Add docs on lightDark theme #2937

alexcarpenter merged 9 commits into from
Jan 20, 2026

Conversation

@alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Jan 8, 2026 •
edited
Loading

🔎 Previews:

What does this solve?

What changed?

  • resolves USER-4297

@alexcarpenter alexcarpenter requested a review from a team as a code owner January 8, 2026 16:07
@vercel
Copy link

vercel bot commented Jan 8, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
clerk-docs Ready Ready Preview Jan 20, 2026 4:58pm

Request Review

SarahSoutoul
SarahSoutoul reviewed Jan 8, 2026
View reviewed changes
alexisintech
alexisintech reviewed Jan 8, 2026
View reviewed changes
@alexcarpenter alexcarpenter mentioned this pull request Jan 8, 2026
Merged
9 tasks
alexisintech
alexisintech approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸💖

@alexcarpenter alexcarpenter changed the title chore: Add docs on lightDark theme DO NOT MERGE: chore: Add docs on lightDark theme Jan 8, 2026
@alexcarpenter
Copy link
Member Author

alexcarpenter commented Jan 9, 2026 •
edited
Loading

@alexisintech @SarahSoutoul small tweak, the default theme will support the light-dark functionality vs introducing a new theme.

366e1cb

SarahSoutoul
SarahSoutoul reviewed Jan 9, 2026
View reviewed changes
alexcarpenter
alexcarpenter commented Jan 9, 2026
View reviewed changes
@SarahSoutoul
Copy link
Contributor

SarahSoutoul commented Jan 9, 2026

@alexcarpenter these two sections are still using @clerk/themes. If I'm not mistaken, it should be '@clerk/ui/themes'?

Screenshot 2026-01-09 at 11 06 17 am Screenshot 2026-01-09 at 11 06 22 am

SarahSoutoul
SarahSoutoul approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@SarahSoutoul SarahSoutoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@alexcarpenter alexcarpenter changed the title DO NOT MERGE: chore: Add docs on lightDark theme chore: Add docs on lightDark theme Jan 20, 2026
@alexcarpenter alexcarpenter merged commit 609b69d into core-3 Jan 20, 2026
1 check passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/light-dark-theme branch January 20, 2026 16:57
alexcarpenter added a commit that referenced this pull request Jan 20, 2026
@alexcarpenter
chore: Add docs on lightDark theme (#2937)
ca1dd58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SarahSoutoul SarahSoutoul SarahSoutoul approved these changes

@alexisintech alexisintech alexisintech approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexcarpenter @SarahSoutoul @alexisintech