-
Notifications
You must be signed in to change notification settings - Fork 934
Components/ hooks contributing guide #2820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KILLER work sarah, love it!! 😸💖 makes a lot of sense to me but lets get @manovotny eyes on it, because he has fresher eyes than me 🙏
Co-authored-by: Alexis Aguilar <[email protected]>
manovotny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great job, @SarahSoutoul!
All of my suggestions are completely optional. You can keep or discard any of them you'd like.
Co-authored-by: Michael Novotny <[email protected]>
Co-authored-by: Michael Novotny <[email protected]>
Co-authored-by: Michael Novotny <[email protected]>
What does this solve?
Given the recent changes for hooks and components, we needed a contributing guide to help anyone who need to add changes to that documentation - see PRs below for context:
What changed?
styleguidesto be able to make a separate contributing guide just for hooks and componentsImportant note: I am tempted to add a table of contents regardless of having things broken up for ease of read. Let me know thoughts and I can add.
Checklist