-
Notifications
You must be signed in to change notification settings - Fork 909
Rename Expo and React packages #2801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
||
| ```npm | ||
| npm install @clerk/clerk-expo@latest | ||
| npm install @clerk/clerk-expo@^2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be left as latest, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a guide specifically for upgrading to Expo v2, so I didn't think it made sense to have it upgrade folks to v3. There is a question though of whether it makes sense to retain this guide at all, but that's above my pay grade 😅
| 1. In the Clerk Dashboard, navigate to your development instance's [**Settings**](https://dashboard.clerk.com/~/settings) page and toggle on **Enable URL-based session syncing**. | ||
| - This toggle is not available in Clerk apps created after December 6th, 2022. | ||
| 1. In your codebase, upgrade `@clerk/clerk-react` to v4.4.5 or later. If your are importing `@clerk/clerk-js` to your project, use v4.18.0 or later. | ||
| 1. In your codebase, upgrade `@clerk/react` to v4.4.5 or later. If your are importing `@clerk/clerk-js` to your project, use v4.18.0 or later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the package rename be backwards compatible, where it can pick up older versions even though the new package name didn't exist until later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this one is tricky. @clerk/clerk-react will cap out in the 5.0.0 version range, and @clerk/react will start with version 6.0.0. Maybe something like this?
In your codebase, upgrade
@clerk/clerk-reactto v4.4.5 or later, or migrate to@clerk/react.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that suggestion.
Similar wording may also be needed in:
| bun add @clerk/clerk-expo | ||
| bun add @clerk/expo | ||
| ``` | ||
| </CodeBlockTabs> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can replace all of CodeBlockTabs with the following and it will automatically create yarn, pnpm, and bun commands.
```npm
npm install @clerk/expo
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I do that refactor in this PR though? It seems like that'd be a bigger docs-wide effort. Happy to update the blocks I'm touching though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, just seeing this. I merged this PR recently to update the blocks to the new markdown, but it seems like I missed a couple of ones. I'll make those fixes in a diff PR so don't worry about it @dstaley - we can merge mine first, and then yours.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR here: #2809
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All merged now! @dstaley
We've made the required changes in the Core 3 branch over in |
|
This PR modifies files in the 'clerk-typedoc/' folder. These files are auto-generated from the clerk/javascript repository and should not be edited directly. To make changes to TypeDoc documentation:
Thanks for contributing! 🙏 |
|
Seems like some |
2d10f0c to
2289c6a
Compare
|
Sorry about that @dstaley - a bit of a messy git issue. But all fixed now. |
Actually, the code examples are now written directly into the docs for hooks, so there might be less changes involved on the |

🔎 Previews:
What does this solve?
clerk-prefix. This PR replaces instances of the previous package names with their new versions.What changed?
@clerk/clerk-expowith@clerk/expo@clerk/clerk-reactwith@clerk/reactChecklist