Add guides for native Sign in with Google in Expo and document useSig…#2786
Add guides for native Sign in with Google in Expo and document useSig…#2786chriscanin wants to merge 30 commits intomainfrom
Conversation
…nInWithGoogle hook
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@chriscanin have pushed my docs review here - let me know your thoughts. Feel free to put it back in draft as we discussed if it needs to be retweaked. A lot of the changes I submitted are consistency + docs voice changes. |
…ble names and remove outdated package reference
…plugin array formatting
|
@chriscanin have left the second docs review after your recent changes: docs review pt 2 after changes. Have a look and let me know your thoughts. I want to double check a few more things and test out the flow, and then it should be good. |
|
@alexisintech I have created another PR and drafted it, this new PR will be for the core-3 release, to ensure when core-3 goes out, our docs are updated. |
| ```bash {{ filename: 'terminal' }} | ||
| # Using EAS Build | ||
| eas build --platform ios | ||
| eas build --platform android | ||
|
|
||
| # Or using local prebuild | ||
| npx expo prebuild && npx expo run:ios --device | ||
| npx expo prebuild && npx expo run:android --device | ||
| ``` |
There was a problem hiding this comment.
Slight suggestion that doesn't need to be taken. But, I was thinking we could also have this under <Tabs> with Android and iOS as options, like we did for the rest of the file. @alexisintech
There was a problem hiding this comment.
yeah i considered that too! 🧠 👯 was going to test android first, and see what in the entire doc was going to get updated (bc i'm still not sure if tabs is the right direction, but won't know until we test android)
| title: "A Google Developer account is required.", | ||
| link: "https://console.developers.google.com/", | ||
| icon: "user-circle", | ||
| } | ||
| }, | ||
| { | ||
| title: "Follow the Android quickstart", | ||
| link: "/docs/android/getting-started/quickstart", | ||
| icon: "android", | ||
| }, |
There was a problem hiding this comment.
@alexisintech Not a massive issue, but do we want to align the order of these to be consistent with the order in the Expo guide.
Expo
Android
| > | ||
| > --- | ||
| > | ||
| > `app.json` is for projects using static JSON configuration (simpler projects). `app.config.ts` is for projects that need dynamic configuration (environment variables, conditional logic, etc.). The `app.config.ts` is the TypeScript version of `app.json` and will overwrite `app.json` with any values that it has. |
There was a problem hiding this comment.
app.json is for projects using static JSON configuration. app.config.ts is for projects that need dynamic configuration (environment variables, conditional logic, etc.). When both files exist, app.config.ts receives the values from app.json and can extend or override them. Choose the tab below based on which configuration approach your project uses.
|
update: the web browser version of sign in with google is working, chris is getting the native version working and then we will test that for ios, and then test the guide for android 👍 |
docs/guides/configure/auth-strategies/sign-in-with-google.expo.mdx
Outdated
Show resolved
Hide resolved
|
Do we need to be closing this PR? @chriscanin |
|
Still trying to get the fix that these documents are for validated! It's on main but having some troubles, working on it now. |
i think we were going to focus on the core 3 pr though, right? like we can close this one since it's for core 2? |
|
@alexisintech Yes, is this the docs PR for the core-2 google sign in? If so, then I think we can close this. |
yup the core 3 one is here: Core 3: Add expo google universal sign in |
3 participants
🔎 Previews:
What does this solve?
useSignInWithGoogle()hook API, parameters, return values, and error handlingFiles Added:
docs/reference/expo/use-google-sign-in.mdx- Complete API reference for the useSignInWithGoogle() hookdocs/guides/configure/auth-strategies/sign-in-with-google.expo.mdx- Comprehensive setup guide for Google Sign-InWhat changed?
Added API Reference Documentation: Created complete reference for
useSignInWithGoogle()hook including:createdSessionId,setActive,signIn,signUp)Added Setup Guide: Created detailed setup guide covering:
Checklist