Skip to content

Conversation

@SarahSoutoul
Copy link
Contributor

🔎 Previews:

What does this solve?

This PR addresses feedback from a user regarding having to update the permissions in roles / permissions for admins to manage / read billing. There isn't much context to the ticket, but here it is. So, had to dive a bit deeper into this one, and found that system permissions do include Read billing and Manage billing, as seen on the image below:

Screenshot 2025-06-04 at 10 39 25 am

However, those aren't listed on the docs:

Screenshot 2025-06-04 at 10 49 11 am

I figured that was where the misunderstanding came from the user. But, not 100% sure why they say they had to update the permission for those if they're already included in the system permissions. I may be missing something here, so keen to hear thoughts.

Linear: https://linear.app/clerk/issue/DOCS-10394/update-docs-to-mention-permissions-needed-for-org-admins-to-manage

What changed?

  • Added Read billing and Manage billing system permissions to the list
  • Lowercased organization twice to be consistent with rest of the list

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • All existing checks pass

@SarahSoutoul SarahSoutoul self-assigned this Jun 4, 2025
@SarahSoutoul SarahSoutoul requested a review from a team as a code owner June 4, 2025 18:04
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Hey, here’s your docs preview: https://clerk.com/docs/pr/2290

Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch! we can also email the user to get more information :)

@SarahSoutoul SarahSoutoul merged commit 8617c63 into main Jun 6, 2025
16 checks passed
@SarahSoutoul SarahSoutoul deleted the ss/DOCS-10394 branch June 6, 2025 16:50
@alexisintech
Copy link
Member

ahh it looks like there was lint failures @SarahSoutoul always check your lint failures before merging! could you please push create a PR with fixes for these errors? they're causing main to fail

@SarahSoutoul
Copy link
Contributor Author

SarahSoutoul commented Jun 7, 2025

ahh it looks like there was lint failures @SarahSoutoul always check your lint failures before merging! could you please push create a PR with fixes for these errors? they're causing main to fail.

I don't think it's this PR that had some errors, because I just checked the branch and main and there is no linting issues. I had checked before merging. What's making things to fail is these two PRs:

This is also a PR I had created a while ago and everything was passing until the two PRs above got created.

See Slack context here: https://clerkinc.slack.com/archives/C01QFRQNHSN/p1749328413058499?thread_ts=1749293319.362799&cid=C01QFRQNHSN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants