-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memory operation tests #90
Conversation
then | ||
trace "~g~~h~~h~0A8C (write_memory), #7 PASSED" | ||
else | ||
breakpoint "~r~~h~~h~~h~0A8C (write_memory), #7 FAILED!~n~ Expected~n~100.0 Found %f" 0@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use same format as in other tests. Values are first in line, so they are easy to compare one under another.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally for opcodes operating with memory I'm checking also neighbour variables to be sure changes were limited only to expected area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All you had to do was to copy entire test case from above and change one variable to float :)
wait 0 | ||
|
||
const LOAD_LIBRARY = 0x00858070 | ||
int load_library_addr = read_memory LOAD_LIBRARY 4 false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually divide test into multiple steps with logging, so if other opcode crashes it is possible to find it out in the log.
Now we just know the problem is somewhere in that file.
If there is compilation script then all compiled files can be removed from the repo. Is SB3 mode active or not in the command line triggered compilation? Is it consistent or relays on current user's SB state? Should any paths be fixed is some tests? |
in current version SB3_compat is enabled by default. It may change in the future. You can enforce this via |
No description provided.