Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory operation tests #90

Merged
merged 10 commits into from
Mar 3, 2024
Merged

memory operation tests #90

merged 10 commits into from
Mar 3, 2024

Conversation

x87
Copy link

@x87 x87 commented Mar 3, 2024

No description provided.

@x87 x87 requested a review from MiranDMC March 3, 2024 05:22
then
trace "~g~~h~~h~0A8C (write_memory), #7 PASSED"
else
breakpoint "~r~~h~~h~~h~0A8C (write_memory), #7 FAILED!~n~ Expected~n~100.0 Found %f" 0@
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use same format as in other tests. Values are first in line, so they are easy to compare one under another.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally for opcodes operating with memory I'm checking also neighbour variables to be sure changes were limited only to expected area.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All you had to do was to copy entire test case from above and change one variable to float :)

wait 0

const LOAD_LIBRARY = 0x00858070
int load_library_addr = read_memory LOAD_LIBRARY 4 false
Copy link
Collaborator

@MiranDMC MiranDMC Mar 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually divide test into multiple steps with logging, so if other opcode crashes it is possible to find it out in the log.
Now we just know the problem is somewhere in that file.

@MiranDMC
Copy link
Collaborator

MiranDMC commented Mar 3, 2024

If there is compilation script then all compiled files can be removed from the repo.

Is SB3 mode active or not in the command line triggered compilation? Is it consistent or relays on current user's SB state? Should any paths be fixed is some tests?

@x87
Copy link
Author

x87 commented Mar 3, 2024

If there is compilation script then all compiled files can be removed from the repo.

Is SB3 mode active or not in the command line triggered compilation? Is it consistent or relays on current user's SB state? Should any paths be fixed is some tests?

in current version SB3_compat is enabled by default. It may change in the future. You can enforce this via --debug parameter

@x87 x87 merged commit 27cb5dc into master Mar 3, 2024
@x87 x87 deleted the tests branch March 3, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants