Opcode string params handling tweaked #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x87
reviewed
Feb 27, 2024
MiranDMC
force-pushed
the
CLEO_read_string_exports_rework
branch
from
6c19057 to
35754a8
Compare
x87
reviewed
Feb 29, 2024
x87
reviewed
Feb 29, 2024
x87
reviewed
Feb 29, 2024
x87
reviewed
Feb 29, 2024
x87
reviewed
Mar 1, 2024
x87
reviewed
Mar 1, 2024
…xport. Restored separated internal buffers for CLEO_ReadStringOpcodeParam and CLEO_ReadStringPointerOpcodeParam sdk exports. Updated opcode param string read util to refect old CLEO general approach and try to use raw source text data whenever possible. Optimized out unnecessary text copying to internal buffer.
MiranDMC
force-pushed
the
CLEO_read_string_exports_rework
branch
from
f2d056f to
f761bdf
Compare
x87
reviewed
Mar 1, 2024
x87
reviewed
Mar 1, 2024
x87
reviewed
Mar 1, 2024
x87
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restored original behavior of CLEO_ReadStringPointerOpcodeParam sdk export.
Restored separated internal buffers for CLEO_ReadStringOpcodeParam and CLEO_ReadStringPointerOpcodeParam sdk exports. Updated opcode param string read util macro to reflect old CLEO general approach and try to use raw source text data whenever possible.
Optimized out unnecessary text copying to internal buffer.
Fixes problem with RZML Trainer