Add callbacks for opcode processing events #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x87
reviewed
Oct 26, 2023
cleo_sdk/CLEO.h
Outdated
Comment on lines
134
to
135
| ScriptOpcodeProcess, // OpcodeResult WINAPI OnScriptOpcodeProcess(CRunningScript* pScript, DWORD opcode); // return other than OR_NONE to signal that opcode was handled in the callback | ||
| ScriptOpcodeProcessed, // OpcodeResult WINAPI OnScriptOpcodeProcessed(CRunningScript* pScript, DWORD opcode, OpcodeResult result); // return other than OR_NONE to overwrite original result |
There was a problem hiding this comment.
Suggested change
| ScriptOpcodeProcess, // OpcodeResult WINAPI OnScriptOpcodeProcess(CRunningScript* pScript, DWORD opcode); // return other than OR_NONE to signal that opcode was handled in the callback | |
| ScriptOpcodeProcessed, // OpcodeResult WINAPI OnScriptOpcodeProcessed(CRunningScript* pScript, DWORD opcode, OpcodeResult result); // return other than OR_NONE to overwrite original result | |
| ScriptOpcodePreProcess, // OpcodeResult WINAPI OnScriptOpcodeProcess(CRunningScript* pScript, DWORD opcode); // return other than OR_NONE to signal that opcode was handled in the callback | |
| ScriptOpcodePostProcess, // OpcodeResult WINAPI OnScriptOpcodeProcessed(CRunningScript* pScript, DWORD opcode, OpcodeResult result); // return other than OR_NONE to overwrite original result |
There was a problem hiding this comment.
Um sounds like preprocessor step. This callback can also do processing by itself.
x87
reviewed
Oct 26, 2023
| if(opcode > LastCustomOpcode) | ||
| // execute registered callbacks | ||
| OpcodeResult result = OR_NONE; | ||
| for (void* func : GetInstance().GetCallbacks(eCallbackId::ScriptOpcodeProcess)) |
There was a problem hiding this comment.
Suggested change
| for (void* func : GetInstance().GetCallbacks(eCallbackId::ScriptOpcodeProcess)) | |
| for (void* func : GetInstance().GetCallbacks(eCallbackId::ScriptOpcodePreProcess)) | |
x87
reviewed
Oct 26, 2023
source/CCustomOpcodeSystem.cpp
Outdated
|
|
||
| // execute registered callbacks | ||
| OpcodeResult callbackResult = OR_NONE; | ||
| for (void* func : GetInstance().GetCallbacks(eCallbackId::ScriptOpcodeProcessed)) |
There was a problem hiding this comment.
Suggested change
| for (void* func : GetInstance().GetCallbacks(eCallbackId::ScriptOpcodeProcessed)) | |
| for (void* func : GetInstance().GetCallbacks(eCallbackId::ScriptOpcodePostProcess)) | |
x87
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.