Audio plugin #63
Audio plugin #63
Conversation
MiranDMC
force-pushed
the
audio_plugin
branch
from
c40ddc0 to
3b8a255
Compare
cleo_plugins/Audio/Audio.cpp
Outdated
| auto stream = (CAudioStream*)OPCODE_READ_PARAM_PTR(); VALIDATE_STREAM(); | ||
|
|
||
| auto length = stream->GetLength(); | ||
| length /= max(stream->GetSpeed(), 0.000001f); // speed corrected |
There was a problem hiding this comment.
I feel like there should be a way to get unscaled stream length. If you watch a video on 2x speed the player does not change the total length. Maybe this opcode should return length as-is, and new 2501 get_audiostream_length_scaled would return it scaled to the speed?
There was a problem hiding this comment.
To get unscaled length just do not change the default speed (1.0). It is only affected by user set speed, not by game speed multiplier.
General idea was to keep it consistent with already existing behaviour as previously there was no way to change speed. It seems to make sense to ask "how long will this track play". Then use it as wait opcode argument.
Updated to handle 0.0 case separately.
There was a problem hiding this comment.
It seems to make sense to ask "how long will this track play".
this what new 2501 opcode is for. I don't see why we need two opcodes doing same
There was a problem hiding this comment.
Original opcode was returning length as seconds in form of floored integer.
Updated to keep the old opcode behaviour unchanged.
There was a problem hiding this comment.
Ok. Last thing is the 2501 name. "Fine" is ambiguous word and can mean different things. It's probably unclear what this command does without reading the description.
Let's call it GET_AUDIO_STREAM_LENGTH_SCALED_TO_SPEED. A little verbose, but has clear meaning.
Alternatives: GET_AUDIO_STREAM_LENGTH_SCALED
GET_AUDIO_STREAM_DURATION
| auto stream = (CAudioStream*)OPCODE_READ_PARAM_PTR(); VALIDATE_STREAM(); | ||
| auto speed = OPCODE_READ_PARAM_FLOAT(); | ||
|
|
||
| stream->SetSpeed(speed); |
There was a problem hiding this comment.
probably should disallow speed of 0. one should pause stream instead
There was a problem hiding this comment.
Intended. There is opcode allowing to perform smooth speed transition. So transitioning to 0.0 is useful to stop the audio with "tape scratch" effect.
Yes, speed 0 changes stream's state to paused, but still the stream speed property should be 0 after that operation. State and speed are two separated properties.
cleo_plugins/Audio/CSoundSystem.cpp
Outdated
|
|
||
| void CAudioStream::SetVolume(float val, float transitionTime) | ||
| { | ||
| if (val < 0.0f) // just update |
There was a problem hiding this comment.
lets make a separate method UpdateVolume() instead of calling SetVolume(-1.0f). it makes the code easier to understand
cleo_plugins/Audio/CSoundSystem.cpp
Outdated
| if (state != playing && !force) return; // done | ||
|
|
||
| SetSpeed(-1.0f); | ||
| SetVolume(-1.0f); |
cleo_plugins/Audio/CSoundSystem.cpp
Outdated
|
|
||
| void C3DAudioStream::Set3dSize(float radius) | ||
| { | ||
| BASS_ChannelSet3DAttributes(streamInternal, BASS_3DMODE_NORMAL, radius, 1E+12f, -1, -1, -1.0f); |
There was a problem hiding this comment.
BASS internally uses some weird decay curve calculations. I don't know what they used for this parameter as default but it seems to be insufficient. This parameter only stops volume decay after that distance is reached.
| } | ||
|
|
||
| //2506=2,set_audio_stream_source_size %1d% radius %2d% | ||
| static OpcodeResult __stdcall opcode_2506(CScriptThread* thread) |
There was a problem hiding this comment.
since this is a property of 3D stream the opcode should be
set_3d_audio_stream_source_size
and belong to class AudioStream3D
There was a problem hiding this comment.
also consider alternative name: set_3d_audio_stream_distance
There was a problem hiding this comment.
This is used to set 3d sound source sphere radius. "distance" would suggest this is related to max hearing distance.
|
the rest looks good to me, thanks |
MiranDMC
force-pushed
the
audio_plugin
branch
from
73a5f59 to
ea48cd3
Compare
New Audio plugin
Unit test scripts added to release pack