Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String args support for legacy opcodes #61

Merged
merged 9 commits into from
Feb 24, 2024
Merged

String args support for legacy opcodes #61

merged 9 commits into from
Feb 24, 2024

Conversation

MiranDMC
Copy link
Collaborator

@MiranDMC MiranDMC commented Feb 21, 2024 •
edited
Loading

test script:

{$CLEO .cs}
nop

wait 6000

0109: add_score 0 money 10
00BA: print_big 'BJ_05' time 2000 style 4
wait 2000

0109: add_score 0 money 10
0@s = 'UNITY'
00BA: print_big 0@s time 2000 style 4
wait 2000

0109: add_score 0 money 10
0@v = "SASO"
00BA: print_big 0@v time 2000 style 4
wait 2000

0109: add_score 0 money 10
allocate_memory 64 store_to 0@
0AD3: string_format 0@ format "%s" args "STAR"
00BA: print_big 0@ time 2000 style 4
wait 2000

terminate_this_custom_script

@MiranDMC MiranDMC requested a review from x87 February 21, 2024 09:48
@MiranDMC MiranDMC marked this pull request as ready for review February 21, 2024 20:34
@MiranDMC MiranDMC force-pushed the string_args_support_for_legacy_opcodes branch from a027d88 to 092f2ad Compare February 22, 2024 17:57
x87
x87 reviewed Feb 22, 2024
View reviewed changes
source/CCustomOpcodeSystem.cpp Outdated Show resolved Hide resolved
x87
x87 reviewed Feb 22, 2024
View reviewed changes
source/CScriptEngine.cpp Outdated Show resolved Hide resolved
x87
x87 reviewed Feb 22, 2024
View reviewed changes
source/CScriptEngine.cpp Outdated Show resolved Hide resolved
@MiranDMC MiranDMC merged commit 2f19740 into master Feb 24, 2024
@MiranDMC MiranDMC deleted the string_args_support_for_legacy_opcodes branch February 27, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x87 x87 x87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiranDMC @x87