Parameters validation in call_function opcodes. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll_function opcodes.
MiranDMC
force-pushed
the
error_checks_in_function_call_opcodes
branch
from
7b16a43 to
15b1a03
Compare
…s in call_function opcodes.
…s in call_function opcodes.
x87
reviewed
Jan 6, 2024
…s in call_function opcodes.
x87
reviewed
Jan 6, 2024
source/CCustomOpcodeSystem.cpp
Outdated
| test ecx, ecx | ||
| jz call_func_this_end | ||
| mov ecx, struc | ||
| call_func_this_end: |
There was a problem hiding this comment.
micro-optimization:
since you used ecx for intermediate calculations, we could assign ecx to struct regardless of thisCall value. It could be a garbage value, could be not, the callee will use it if needed.
ie.
// set struct pointer for this call
mov ecx, struc
// call function
xor eax, eax
call func
There was a problem hiding this comment.
True. Even better, as unused struc has value 0.
Updated.
x87
approved these changes
Jan 6, 2024
…s in call_function opcodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated string params handling.