forget_memory opcode #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiranDMC
changed the title
MiranDMC
force-pushed
the
opcode_alloc_memory_persistent
branch
from
7260bd0 to
58e57d0
Compare
MiranDMC
force-pushed
the
opcode_alloc_memory_persistent
branch
from
58e57d0 to
d846e70
Compare
x87
reviewed
Jan 6, 2024
source/CCustomOpcodeSystem.cpp
Outdated
| if (mem) GetInstance().OpcodeSystem.m_pAllocations.insert(mem); | ||
| DWORD size; *thread >> size; | ||
|
|
||
| void* mem = malloc(size); |
There was a problem hiding this comment.
should we switch over to calloc here? I'm not sure how breaking this change might be, but I couldn't imagine any script specifically relying on uninitialized memory
There was a problem hiding this comment.
Reasonable. Updated.
x87
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New opcode for removing memory blocks allocated with 0A8C from clean-up list used when starting new game/loading save.
Added virtual protect configuration to 0A8C, to allow hosting executable code.