Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Workflows, Add Dependabot #52

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Update Workflows, Add Dependabot #52

merged 3 commits into from
Apr 2, 2024

Conversation

CanerKaraca23
Copy link

No description provided.


- uses: actions/upload-artifact@v4
with:
compression-level: 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No compression at all?

Copy link
Author

@CanerKaraca23 CanerKaraca23 Dec 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No compression at all?

You can change it by 0-9, i left it for you, 6 is default. Artifact comes ~1mb anyway without compression. It decreases compile time.

@MiranDMC MiranDMC requested a review from x87 December 23, 2023 14:45
@CanerKaraca23
Copy link
Author

@x87 review?

@x87
Copy link

x87 commented Apr 2, 2024

@x87 review?

well, what to say? I don't think we need dependabot, also what the test build is for? other than bumping action packages to more recent versions I don't see actual improvements.

#11 this would be more useful if you have experience with github ci

@CanerKaraca23
Copy link
Author

CanerKaraca23 commented Apr 2, 2024

@x87 review?

well, what to say? I don't think we need dependabot, also what the test build is for? other than bumping action packages to more recent versions I don't see actual improvements.

#11 this would be more useful if you have experience with github ci

You know. Dependabot will update submodules. Updating action packages will not harm you. Also test CI is for testing pull requests if it's passing or not.

You can close PR if you want. Thanks.

@x87
Copy link

x87 commented Apr 2, 2024

I see. I had mostly negative experience with dependabot in my projects as I was overwhelmed with minor package updates (see here for example).

We can try it out and if it get too annoying, we will disable.

@x87 x87 merged commit e01844d into cleolibrary:master Apr 2, 2024
@CanerKaraca23
Copy link
Author

I see. I had mostly negative experience with dependabot in my projects as I was overwhelmed with minor package updates (see here for example).

We can try it out and if it get too annoying, we will disable.

You can always configure Dependabot for example group the updates, check updates weekly or monthly and configure only for major updates. It will not spam minor updates. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants