Implemented proper handling of game start-end events. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiranDMC
force-pushed
the
proper_game_start_end_handling
branch
2 times, most recently
from
379787f to
ff6621f
Compare
Fixed multiple execution of scripts during new game start.
MiranDMC
force-pushed
the
proper_game_start_end_handling
branch
from
ff6621f to
5446503
Compare
MiranDMC
changed the title
x87
reviewed
Dec 3, 2023
| void(__cdecl* GameRestart3)() = nullptr; | ||
| static void __cdecl OnGameRestart1(); | ||
| static void __cdecl OnGameRestart2(); | ||
| static void __cdecl OnGameRestart3(); |
There was a problem hiding this comment.
@MiranDMC can you document in wiki what events and CLEO callbacks are executed when we
- start a new game
- start a game from a save file
- loading another save
- exiting game
There was a problem hiding this comment.
x87
reviewed
Dec 3, 2023
source/CScriptEngine.cpp
Outdated
|
|
||
| gangWeapons[7].weapon[0] = 22; | ||
| gangWeapons[7].weapon[1] = 28; | ||
| gangWeapons[7].weapon[2] = 0; |
There was a problem hiding this comment.
I don't know why we make this for EU 1.01 specifically. CLEO does not work here anyway. Let's delete this, it's not CLEO business
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed multiple execution of scripts during new game start.