Argument count mismatch validation in 0AB2 split into critical and non critical cases. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n critical cases.
x87
reviewed
Nov 11, 2023
| @@ -2304,11 +2304,15 @@ namespace CLEO | |||
| return CCustomOpcodeSystem::ErrorSuspendScript(thread); | |||
| } | |||
|
|
|||
| if(returnParamCount - 1 != declaredParamCount) // minus 'num args' itself | |||
There was a problem hiding this comment.
Should we disable this check only in CLEO4 compat mode (.cs4 extension)?
So if there is a broken mod working in CLEO4, they could try renaming to .cs4
There was a problem hiding this comment.
Currently screen log can be disabled, but stop logging from script that won't be fixed anyway seems better idea.
Do cs4 files has any other behaviour differences at this moment?
There was a problem hiding this comment.
I don't know, perhaps we should have a separate doc file which would list all differences for .cs4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26